Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app router 404 #2155

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix app router 404 #2155

merged 2 commits into from
Dec 18, 2023

Conversation

dhmacs
Copy link
Contributor

@dhmacs dhmacs commented Dec 15, 2023

closes https://github.com/iFixit/ifixit/issues/51164

No need to QA this as there's no url showing this 404 yet

qa_req 0

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 3:28pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 3:28pm

@ghost
Copy link

ghost commented Dec 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

github-actions bot commented Dec 15, 2023

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@danielcliu-ifixit
Copy link
Member

CR ✌️

Copy link
Member

@davidrans davidrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ☕

@davidrans davidrans merged commit 87d6687 into main Dec 18, 2023
15 checks passed
@davidrans davidrans deleted the fix-404-async branch December 18, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants