-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stars: Make reviews accessible #2157
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a48cd61
to
b73fd7e
Compare
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 💯
Productlist:@jarstelfox, I noticed on main that the number of reviews on a productlist page is read. On this branch it isn't. When I scroll through the elements on this branch, I get the appropriate "Rated ${product.reviews.rating} out of 5 stars" read aloud to me, but it skips to the price instead of reading aloud the number of reviews. That number already wasn't clear on main because it was just a number read out, but now (on this branch) it's not read at all. Product PageWorks. Tabbing through, I get the price, "Rated ${product.reviews.rating} out of 5 stars", and then "# reviews" |
Fixed |
Yep. QA 🍰 It's now reading me: "Rated ${product.rating} out of 5 stars with ${product.rating_count} reviews" on productlist pages. Using a screen reader to interact with the star count on productlist and product pages is now much nicer. The screen reader reads the product rating and the review count clearly on both page types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ⚪
QA
Connects: https://github.com/iFixit/ifixit/issues/51161