Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars: Make reviews accessible #2157

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Stars: Make reviews accessible #2157

merged 4 commits into from
Dec 15, 2023

Conversation

jarstelfox
Copy link
Contributor

@jarstelfox jarstelfox commented Dec 15, 2023

QA

  • Ensure you screen reader now reads the rating

Connects: https://github.com/iFixit/ifixit/issues/51161

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 11:00pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 11:00pm

@ghost
Copy link

ghost commented Dec 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

github-actions bot commented Dec 15, 2023

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

ianrohde
ianrohde previously approved these changes Dec 15, 2023
Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 💯

@erinemay
Copy link
Contributor

erinemay commented Dec 15, 2023

Productlist:

@jarstelfox, I noticed on main that the number of reviews on a productlist page is read. On this branch it isn't. When I scroll through the elements on this branch, I get the appropriate "Rated ${product.reviews.rating} out of 5 stars" read aloud to me, but it skips to the price instead of reading aloud the number of reviews.

That number already wasn't clear on main because it was just a number read out, but now (on this branch) it's not read at all.

image

Product Page

Works. Tabbing through, I get the price, "Rated ${product.reviews.rating} out of 5 stars", and then "# reviews"

@erinemay erinemay removed the QAing Under QA team review label Dec 15, 2023
@jarstelfox
Copy link
Contributor Author

Fixed

@erinemay
Copy link
Contributor

Fixed

Yep. QA 🍰 It's now reading me: "Rated ${product.rating} out of 5 stars with ${product.rating_count} reviews" on productlist pages.

Using a screen reader to interact with the star count on productlist and product pages is now much nicer. The screen reader reads the product rating and the review count clearly on both page types.

Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚪

@davidrans davidrans merged commit c3516da into main Dec 15, 2023
15 checks passed
@davidrans davidrans deleted the stars-aria-iy-up branch December 15, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants