-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Strapi product list redirect fields #2165
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3156de5
to
1d4952f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🌵
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
I feel like this is complexity that isn't really needed. We have to add another query to the graphQL query and it allows there to be two places where the same data is stored and thus there can be conflicts:
Where do we go when visiting Y? |
You're right, it's not necessary, but it could be nice to see which product lists redirect to the one you're looking at. It is also a visual cue to help Strapi admin users prevent redirect chains.
I don't think Strapi allows there to be conflicts. When you add a We do not have to query for |
Oh! I didn't understand the Thanks for explaining! |
Connects #2067
The intent is to grab
redirectTo
at request time (cached with Redis) and issue a redirect if appropriate.redirectFrom
isn't necessary for the Next.js app, but offers a convenient way for Strapi admin users to create redirects from a source to a target from the source product list page. (e.g. If I am on product list A and want to cause product list B to redirect to product list A, I can do so without visiting product list B in Strapi admin).https://docs.strapi.io/dev-docs/backend-customization/models#relations
qa_req 0