Vulcan: Problem List: Ancestor problem lists #2231

ianrohde · 2024-02-06T23:53:03Z

Issue

Add ancestor Problems to Problems List page when available. See issue description for further details.

Mock-up text is not final. Figure out final copy with Max.

Text will be updated separately in https://github.com/iFixit/ifixit/issues/51815

CR/QA

/Troubleshooting/dryer (no ancestors)
/Troubleshooting/AEG_T865901H_dryer (has ancestors)

Closes https://github.com/iFixit/ifixit/issues/51062

Co-authored-by: Andrew Gilbert <[email protected]>

vercel · 2024-02-06T23:53:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
react-commerce	✅ Ready (Inspect)	Visit Preview	Feb 7, 2024 6:56pm
react-commerce-prod	✅ Ready (Inspect)	Visit Preview	Feb 7, 2024 6:56pm

ghost · 2024-02-06T23:53:41Z

👇 Click on the image for a new way to code review

Legend

github-actions · 2024-02-06T23:56:00Z

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

hcutrone

CR 🌯 Looks good to me!

kthaler · 2024-02-07T02:08:49Z

QA 💎 - When a device has problem pages, and it's ancestor also has problem pages, the device's troubleshooting page will display it's own problem pages, and in a second heading it will show it's ancestor's problem pages.

deploy_block 🦖

What is expected when there are a hierarchy of children with problem pages? Should a child-of-a-child device inherit the base problem pages or it's own parent problem pages, or both? For example, I made a child of the AEG T865901H dryer device and gave it a troubleshooting page: https://me.cominor.com/Device/child_test . In the troubleshooting section of the device page, only the dryer troubleshooting pages are inherited, and not the AEG T865901H dryer troubleshooting page. In the Troubleshooting page of the child device, the AEG T865901H dryer Troubleshooting page isn't there, only the dryer pages.

Text will be updated separately in https://github.com/iFixit/ifixit/issues/51815

Not sure if my issue applies then, so please disregard if this isn't in the scope of the pull.
At widths of 767px to 575px, the h2 heading seems too close to the navbar. Video:

Screen.Recording.2024-02-06.at.5.19.43.PM.mov

ianrohde · 2024-02-07T16:01:04Z

At widths of 767px to 575px, the h2 heading seems too close to the navbar.

This should be corrected, thanks!

Fixed in 4f95bc5

andyg0808 · 2024-02-07T16:34:34Z

What is expected when there are a hierarchy of children with problem pages? Should a child-of-a-child device inherit the base problem pages or it's own parent problem pages, or both?

The troubleshooting pages of a device with the inheritance flag are inherited by all its child devices. No pages from child devices are inherited by more distant descendants.
For full details, here's the spec: https://github.com/iFixit/ifixit/issues/48260

For example, I made a child of the AEG T865901H dryer device and gave it a troubleshooting page: me.cominor.com/Device/child_test. In the troubleshooting section of the device page, only the dryer troubleshooting pages are inherited, and not the AEG T865901H dryer troubleshooting page.

👍 That's what we want. We can add the inheritance flag to the AEG T865901H dryer to have its troubleshooting pages also get inherited, at which point the child_test device should have both Dryer and AEG T865901H troubleshooting pages.

un_deploy_block 👶

hcutrone

CR 🌯

deltuh-vee · 2024-02-07T18:28:32Z

QA 🎬
h2 heading is no longer too close to the navbar.
deploy_block ❓
Did you also mean to make this larger?

ianrohde · 2024-02-07T18:37:25Z

~~@deltuh-vee was that observed on the latest preview? I'm not seeing it: https://react-commerce-prod-gi2hw5yqz-ifixit.vercel.app/Troubleshooting/dryer~~

It is larger. I'll set the fontSize statically so heading changes won't modify

Details

ianrohde · 2024-02-07T18:50:53Z

Answers heading fontSize fixed in 35dec8c

un_deploy_block 🟢

deltuh-vee · 2024-02-07T18:59:08Z

QA 🎬
Larger text has been fixed.

hcutrone · 2024-02-07T19:34:05Z

frontend/app/(defaultLayout)/Troubleshooting/[device]/components/Answers.tsx

@@ -17,7 +17,7 @@ export function Answers({
               <Heading
                  as={hasProblems ? 'h4' : 'h3'}
                  color="gray.800"
-                  fontSize={{ base: '24px', sm: '30px' }}
+                  fontSize={{ base: '20px', mdPlus: '24px' }}


Is mdPlus a custom breakpoint we created? I haven't seen it before

Yeah, I added it here: https://github.com/iFixit/react-commerce/pull/2143/files#diff-9e3cebe6686b9c7a2c8f51158b777b7f8d7b7bd53fd8a126776adc1e655bf956R7

tl;dr: Chakra uses min-width @media queries, so we need 'md' + 1px

hcutrone

CR 🌯

Andrew Gilbert and others added 2 commits February 1, 2024 16:07

Put together basic grouped version of problems data

07d72d2

Hook up ancestor Problem data, conditionally render Answers

33b55ba

Co-authored-by: Andrew Gilbert <[email protected]>

vercel bot deployed to Preview – react-commerce-prod February 6, 2024 23:55 View deployment

vercel bot deployed to Preview – react-commerce February 6, 2024 23:57 View deployment

ianrohde marked this pull request as ready for review February 6, 2024 23:58

hcutrone previously approved these changes Feb 7, 2024

View reviewed changes

kthaler self-assigned this Feb 7, 2024

kthaler added the QAing Under QA team review label Feb 7, 2024

kthaler removed the QAing Under QA team review label Feb 7, 2024

Correct wrapper padding breakpoint

4f95bc5

ianrohde dismissed hcutrone’s stale review via 4f95bc5 February 7, 2024 16:10

vercel bot deployed to Preview – react-commerce February 7, 2024 16:14 View deployment

vercel bot deployed to Preview – react-commerce-prod February 7, 2024 16:18 View deployment

hcutrone previously approved these changes Feb 7, 2024

View reviewed changes

deltuh-vee self-assigned this Feb 7, 2024

deltuh-vee added the QAing Under QA team review label Feb 7, 2024

Fix answers heading fontSize

35dec8c

ianrohde dismissed hcutrone’s stale review via 35dec8c February 7, 2024 18:49

vercel bot deployed to Preview – react-commerce-prod February 7, 2024 18:53 View deployment

vercel bot deployed to Preview – react-commerce February 7, 2024 18:56 View deployment

deltuh-vee removed the QAing Under QA team review label Feb 7, 2024

hcutrone reviewed Feb 7, 2024

View reviewed changes

hcutrone approved these changes Feb 7, 2024

View reviewed changes

ianrohde merged commit 4cc92d1 into main Feb 7, 2024
14 checks passed

ianrohde deleted the problem-list--ancestor-problem-lists branch February 7, 2024 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vulcan: Problem List: Ancestor problem lists #2231

Vulcan: Problem List: Ancestor problem lists #2231

ianrohde commented Feb 6, 2024

vercel bot commented Feb 6, 2024 •

edited

Loading

ghost commented Feb 6, 2024 •

edited by ghost

Loading

Legend

github-actions bot commented Feb 6, 2024 •

edited

Loading

hcutrone left a comment

kthaler commented Feb 7, 2024

ianrohde commented Feb 7, 2024 •

edited

Loading

andyg0808 commented Feb 7, 2024

hcutrone left a comment

deltuh-vee commented Feb 7, 2024 •

edited

Loading

ianrohde commented Feb 7, 2024 •

edited

Loading

ianrohde commented Feb 7, 2024

deltuh-vee commented Feb 7, 2024

hcutrone Feb 7, 2024

ianrohde Feb 7, 2024 •

edited

Loading

hcutrone left a comment

Vulcan: Problem List: Ancestor problem lists #2231

Vulcan: Problem List: Ancestor problem lists #2231

Conversation

ianrohde commented Feb 6, 2024

Issue

CR/QA

vercel bot commented Feb 6, 2024 • edited Loading

ghost commented Feb 6, 2024 • edited by ghost Loading

Legend

github-actions bot commented Feb 6, 2024 • edited Loading

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

hcutrone left a comment

Choose a reason for hiding this comment

kthaler commented Feb 7, 2024

ianrohde commented Feb 7, 2024 • edited Loading

andyg0808 commented Feb 7, 2024

hcutrone left a comment

Choose a reason for hiding this comment

deltuh-vee commented Feb 7, 2024 • edited Loading

ianrohde commented Feb 7, 2024 • edited Loading

ianrohde commented Feb 7, 2024

deltuh-vee commented Feb 7, 2024

hcutrone Feb 7, 2024

Choose a reason for hiding this comment

ianrohde Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

hcutrone left a comment

Choose a reason for hiding this comment

vercel bot commented Feb 6, 2024 •

edited

Loading

ghost commented Feb 6, 2024 •

edited by ghost

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

ianrohde commented Feb 7, 2024 •

edited

Loading

deltuh-vee commented Feb 7, 2024 •

edited

Loading

ianrohde commented Feb 7, 2024 •

edited

Loading

ianrohde Feb 7, 2024 •

edited

Loading