Troubleshooting: Match navtab style to /Parts page #2232
Conversation
1. Instead of having separate styles, lets just
import the components that we want to match and
avoid duplicate code.
2. The only difference is that the troubleshooting
tabs can be disabled, so we need to add some
special styling and disable them when there is
no url.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
CR 🌵 but dev_block 🌵 because I think we might want to do the inverse: https://github.com/iFixit/ifixit/issues/51876#issuecomment-1932566537
That's the Problems List component (e.g. |
I used the pre-existing NavBar as the foundation for the Problems List NavBar. They should be close aside from a few small things. This pretty much confirms the value of a shared component |
|
Ah, bummer. Closing this because the changes are significantly different. |
Overview
Reuses the components from the /Parts nav tabs on troubleshooting view pages. Now the styles are consistent across the tabs.
CR
QA
Closes https://github.com/iFixit/ifixit/issues/51876