topic_images api: stop double-encoding params list #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added this in 8552518 along with several other correct url encoding changes. Unfortunately, params.toString() already creates a correctly encoded string and encoding it again creates a doubly-encoded garbage url. That means this api hasn't worked at all since Nov-2023; it's been giving 404s. This was just noticed now because one of our playwright tests loaded a product list page that made this request and resulted in a 404 which failed the test.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
QA 👍 This branch: Live: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this in 8552518 along with several other correct url encoding changes.
Unfortunately, params.toString() already creates a correctly encoded string and encoding it again creates a doubly-encoded garbage url. That means this api hasn't worked at all since Nov-2023; it's been giving 404s.
This was just noticed now because one of our playwright tests loaded a product list page that made this request and resulted in a 404 which failed the test.