[ADD] 1주차 과제 #4
Open
[ADD] 1주차 과제 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push - Navigation 방법
문제점 : (1) 스크롤뷰..... 컬렉션뷰의 끝까지 (2) UI 이상함 (3) 데이터 전달.... (4) + 버튼
hellozo0
requested review from
jane1choi,
EunHee-Jeong,
L-j-h-c and
Suyeon9911
Suyeon9911
approved these changes
Nov 8, 2021
Comment on lines
28
to
47
| homeVC.tabBarItem.title = "홈" | ||
| homeVC.tabBarItem.image = UIImage(named: "homeIcon") | ||
| homeVC.tabBarItem.selectedImage = UIImage(named: "homeIconFill") | ||
|
|
||
| townVC.tabBarItem.title = "동네생활" | ||
| townVC.tabBarItem.image = UIImage(named: "townIcon") | ||
| townVC.tabBarItem.selectedImage = UIImage(named: "townIconFill") | ||
|
|
||
| myaroundVC.tabBarItem.title = "내 근처" | ||
| myaroundVC.tabBarItem.image = UIImage(named: "myAroundIcon") | ||
| myaroundVC.tabBarItem.selectedImage = UIImage(named: "myAroundIconFill") | ||
|
|
||
| chatVC.tabBarItem.title = "채팅" | ||
| chatVC.tabBarItem.image = UIImage(named: "chatIcon") | ||
| chatVC.tabBarItem.selectedImage = UIImage(named: "chatIconFill") | ||
|
|
||
| profileVC.tabBarItem.title = "나의 당근" | ||
| profileVC.tabBarItem.image = UIImage(named: "myCarrotIcon") | ||
| profileVC.tabBarItem.selectedImage = UIImage(named: "myCarrotIconFill") | ||
|
|
There was a problem hiding this comment.
탭바 만들때 !
homeVC.tabBarItem = UITabBarItem(title: "홈", image: UIImage(named: "homeIcon"), selectedImage: UIImage(named: "homeIconFill"))요렇게 생성자를 사용해서 해주면 한줄로 줄어든답니다 !
There was a problem hiding this comment.
@Suyeon9911 오 순배 너무 좋아! 바로 적용해볼께
Suyeon9911
approved these changes
Nov 8, 2021
Comment on lines
+29
to
+41
|
|
||
| // MARK: - Custom Method | ||
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| navigationController?.setNavigationBarHidden(true, animated: animated) | ||
| } | ||
|
|
||
| override func viewWillDisappear(_ animated: Bool) { | ||
| super.viewWillDisappear(animated) | ||
| navigationController?.setNavigationBarHidden(false, animated: animated) | ||
| } | ||
|
|
There was a problem hiding this comment.
저도 이거 써줬어요! 네비게이션컨트롤러 연결하면 투명하게 공간 차지해서 그 아래에 있는 유아이나 버튼이 안 눌리는데 그거 없애주려고 하신듯??
Comment on lines
+72
to
+81
|
|
||
| func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | ||
| let selectProduct = itemDataList[indexPath.row] | ||
| let storyboard = UIStoryboard(name:"ItemDetail", bundle: nil) | ||
|
|
||
| if let ivc = storyboard.instantiateViewController(identifier: "ItemDetailVC") as? ItemDetailVC { | ||
| ivc.itemDataList = selectProduct | ||
| self.navigationController?.pushViewController(ivc, animated: true) | ||
| } | ||
| } |
| guard let cell = tableView.dequeueReusableCell(withIdentifier: ItemTableViewCell.identifier) as? ItemTableViewCell else {return UITableViewCell()} | ||
|
|
||
| cell.setData(like: indexPath.row, appData: itemDataList[indexPath.row]) | ||
| cell.selectionStyle = .none // 셀 선택시 회색 없애기 |
There was a problem hiding this comment.
셀 선택 시 회색 없애는 거 저는 delegate에 didSelectRowAt 에서 해줬어용 ! 그냥 저눈 요러케 했다구 공유한곱니다~
// 셀 선택 해제
tableView.deselectRow(at: indexPath, animated: true)
L-j-h-c
reviewed
Nov 9, 2021
Comment on lines
+29
to
+41
|
|
||
| // MARK: - Custom Method | ||
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| navigationController?.setNavigationBarHidden(true, animated: animated) | ||
| } | ||
|
|
||
| override func viewWillDisappear(_ animated: Bool) { | ||
| super.viewWillDisappear(animated) | ||
| navigationController?.setNavigationBarHidden(false, animated: animated) | ||
| } | ||
|
|
There was a problem hiding this comment.
저도 이거 써줬어요! 네비게이션컨트롤러 연결하면 투명하게 공간 차지해서 그 아래에 있는 유아이나 버튼이 안 눌리는데 그거 없애주려고 하신듯??
Comment on lines
+72
to
+81
|
|
||
| func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | ||
| let selectProduct = itemDataList[indexPath.row] | ||
| let storyboard = UIStoryboard(name:"ItemDetail", bundle: nil) | ||
|
|
||
| if let ivc = storyboard.instantiateViewController(identifier: "ItemDetailVC") as? ItemDetailVC { | ||
| ivc.itemDataList = selectProduct | ||
| self.navigationController?.pushViewController(ivc, animated: true) | ||
| } | ||
| } |
| RecommendItemData(recommenditemIconName: "eunjuchoi", recommenditemName: "은주초이", recommenditemPrice: "999,999+원"), | ||
| RecommendItemData(recommenditemIconName: "eunjuchoi", recommenditemName: "은주초이", recommenditemPrice: "999,999+원"), | ||
| RecommendItemData(recommenditemIconName: "eunjuchoi", recommenditemName: "은주초이", recommenditemPrice: "999,999+원") | ||
| ]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#1 #2 #3
📌 변경 사항 및 이유
이슈 1번에서 상단바, Table View, 하단의 Tabbar
이슈 2번에서 게시글 클릭시 화면전환, 데이터 전달
이슈 3번에서 게시글의 UI, 게시글 뷰의 데이터 관리
📌 PR Point
PR할만큼 잘난게 없네요...
다음부터는 과제 미리미리 하겠습니다... 6시간만에 한거 치고는 ㄱㅊ하지 않나..? 아닌가./.?
📌 참고 사항(못한거)
[이슈1번]
(3. 게시글 눌렀을때 모션 없앴습니다. 그 진회색 보이는거 넘 초보같아서요.. ㅎㅎ)
[이슈2번]
[이슈3번]
아 대박 못한거 왜이리 많아 울고싶게 진짜