Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to work with new raven #106

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

PaulTalbot-INL
Copy link
Collaborator


Pull Request Description

What issue does this change request address?

Continues #74

What are the significant changes in functionality due to this change request?

Updates for the new RAVEN ROM api

Requires idaholab/raven#1684 before testing/merging.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@@ -2,7 +2,7 @@
[./Cashflows]
type = HeronIntegration
input = heron_input.xml
# prereq = SineArma
# prereq = SineArma_30yr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how we will leave this in for anticipation for the prereq flag to work correctly XD

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, will merge upon tests passing. Mostly only minor updates and additions.

@moosebuild
Copy link
Collaborator

moosebuild commented Oct 20, 2021

Job CentOS 8 on 30393b4 : invalidated by @PaulTalbot-INL

Needed to wait for dependent PR in RAVEN; restarting test.

@dylanjm dylanjm merged commit 9f63724 into idaholab:devel Oct 20, 2021
@PaulTalbot-INL PaulTalbot-INL deleted the raven_romapi_fix branch January 31, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants