Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock pyomo version(s) #142

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Unlock pyomo version(s) #142

merged 2 commits into from
Apr 12, 2022

Conversation

dgarrett622
Copy link
Collaborator

@dgarrett622 dgarrett622 commented Apr 1, 2022


Pull Request Description

What issue does this change request address?

Continues #74

What are the significant changes in functionality due to this change request?

Continuing discussion from #124 allows upgrading pyomo from 5.7 as a dependency


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dgarrett622 dgarrett622 added the Do Not Merge PR is not ready for merging label Apr 1, 2022
@dgarrett622 dgarrett622 self-assigned this Apr 1, 2022
@dgarrett622
Copy link
Collaborator Author

This PR was ready to go until the ravenframework change. Need to wait for #140 before attempting to merge.

@PaulTalbot-INL PaulTalbot-INL mentioned this pull request Apr 7, 2022
9 tasks
@moosebuild
Copy link
Collaborator

Job CentOS 8 on 98c71cd : invalidated by @PaulTalbot-INL

ravenframework fix, rerunning tests

@dylanjm dylanjm mentioned this pull request Apr 12, 2022
9 tasks
@dgarrett622 dgarrett622 removed the Do Not Merge PR is not ready for merging label Apr 12, 2022
@dgarrett622 dgarrett622 mentioned this pull request Apr 12, 2022
9 tasks
@PaulTalbot-INL
Copy link
Collaborator

@dgarrett622 This passed tests but is marked with "do not merge"; any opposition to removing that flag?

@dgarrett622
Copy link
Collaborator Author

@PaulTalbot-INL no problems with removing the flag and merging. I tried removing the flag earlier, maybe it didn't stick.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and should not affect functionality or results.

@dylanjm dylanjm merged commit 9d63abc into idaholab:devel Apr 12, 2022
@dgarrett622 dgarrett622 deleted the pyomo_version branch April 19, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants