Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Pyomo Dispatch #326

Merged
merged 14 commits into from
Jan 24, 2024
Merged

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Nov 13, 2023


Pull Request Description

What issue does this change request address?

#332

What are the significant changes in functionality due to this change request?
  • New Files: PyomoRuleLibrary.py PyomoModelHandler.py putils.py

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm dylanjm changed the title [WIP] Refactor Pyomo Dispatch Refactor Pyomo Dispatch Jan 22, 2024
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to address, I think they're all docstrings related tbh.

src/dispatch/PyomoModelHandler.py Outdated Show resolved Hide resolved
src/dispatch/PyomoModelHandler.py Outdated Show resolved Hide resolved
src/dispatch/PyomoModelHandler.py Outdated Show resolved Hide resolved
src/dispatch/PyomoModelHandler.py Outdated Show resolved Hide resolved
src/dispatch/PyomoModelHandler.py Outdated Show resolved Hide resolved
src/dispatch/PyomoRuleLibrary.py Show resolved Hide resolved
src/dispatch/PyomoRuleLibrary.py Show resolved Hide resolved
src/dispatch/PyomoRuleLibrary.py Show resolved Hide resolved
src/dispatch/PyomoRuleLibrary.py Show resolved Hide resolved
src/dispatch/putils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two last docstring fixes

src/dispatch/PyomoModelHandler.py Outdated Show resolved Hide resolved
src/dispatch/PyomoRuleLibrary.py Show resolved Hide resolved
@PaulTalbot-INL
Copy link
Collaborator

Code reviewed and tests passed on most recent code changes (last update is just docstring fixes). Merging.

@PaulTalbot-INL PaulTalbot-INL merged commit 8495d93 into idaholab:devel Jan 24, 2024
3 of 4 checks passed
@dylanjm dylanjm deleted the dispatch-refactor branch March 29, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants