-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #17 #77
Closes #17 #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and will satisfy a long-standing feature request.
@alfoa Looks like there is some trailing whitespace in Cashflows.py |
…EAL into flexibleConstructionTimeCapex
@alfoa Yes, it looks like it's calculating a different NPV for the PyomoTest: I will take a look at it deeper in a little bit. Looks like the new NPV calculation is off by about $840 |
@alfoa I'm able to recreate the PyomoTest failure on my local machine. It appears There is probably something messed up in |
Hi @dylanjm , @yoshiurr-INL it seems you created the test. Advices? |
I close this PR. I ll keep the changes local. If somebody wants to pick this up, the branch still exists in the repository. |
Pull Request Description
What issue does this change request address?
Closes #17
What are the significant changes in functionality due to this change request?
This simple change allows the user to set construction times > 1 unit (year, month, etc) in the Capex cash flow calculation.
In the user manual, the alpha can already be set as an array but if the "driver" is a variable (for example, from raven) only the first "year" entry is taken in consideration. This MR fixes that. No manual modifications have been performed since the manual seems to indicate that this is already possible (even if it is not).
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.