Reduced order model for P91, rev2 #153
Conversation
lynnmunday
force-pushed
the
p91_rom_141_rev2
branch
from
c33f3ad
to
f4bce88
Compare
lynnmunday
force-pushed
the
p91_rom_141_rev2
branch
5 times, most recently
from
e76133b
to
98f1c4b
Compare
| return method implemented in [ADRadialReturnStressUpdate](/ADRadialReturnStressUpdate.md) to | ||
| compute a creep rate. The coefficients are formulated by many precomputed lower-length scale | ||
| simulations, and calibrated to Legendre polynomials. See | ||
| ADLAROMANCEStressUpdateBase](ADLAROMANCEStressUpdateBase.md) for a more extensive review of the |
There was a problem hiding this comment.
Need a [ at the beginning of line 12
|
|
||
| ## Description | ||
|
|
||
| `P91LAROMANCEStressUpdate` implements the necessary coefficients to compute a creep rate for P91 |
There was a problem hiding this comment.
Should we call it Grade 91?
| std::vector<unsigned int> | ||
| P91LAROMANCEStressUpdate::getTilings() | ||
| { | ||
| // indicies are [input] |
There was a problem hiding this comment.
Not sure what this comment means. Also, 'indices' is misspelled.
There was a problem hiding this comment.
I deleted it, I don't know what it means either.
| std::vector<std::vector<std::vector<ROMInputTransform>>> | ||
| P91LAROMANCEStressUpdate::getTransform() | ||
| { | ||
| return {{{ROMInputTransform::LOG, |
There was a problem hiding this comment.
This might be more readable and more consistent with the formatting of the return statement in the function below if we combined the 6 vector entries on each line. There are clang-format overrides to allow you to have longer lines.
test/tests/p91_rom/tests
Outdated
| cli_args = 'Executioner/dt=25 Executioner/num_steps=10' | ||
| petsc_version = '>=3.9.0' | ||
| max_parallel = 1 | ||
| detail = 'in isolation (i.e. without a full displacement solve), and match with code-to-code comparison. Sometimes both codes will produce unrealistic values for the inputs.' |
There was a problem hiding this comment.
What is the code we're comparing with? Also, what is meant by that last sentence? Don't the codes produce outputs, rather than inputs?
test/tests/p91_rom/tests
Outdated
| cli_args = 'Executioner/dt=1 Outputs/file_base=verification_heavy_out' | ||
| max_parallel = 1 | ||
| allow_test_objects = true | ||
| detail = 'in isolation (i.e. without a full displacement solve), and match with code-to-code comparison with a large set of input parameters. Sometimes both codes will produce unrealistic values for the inputs.' |
lynnmunday
force-pushed
the
p91_rom_141_rev2
branch
from
3565c05
to
13ccdee
Compare
added another p91 test that runs a creep simulation reproducing results from the milestone report
lynnmunday
force-pushed
the
p91_rom_141_rev2
branch
from
13ccdee
to
cf536b4
Compare
|
@bwspenc Will you take another look, I made your requested changes. |
I accidentally merged Topher's wip pr after I addressed Stephanies comments. After this passes tests, it can be merged.
Daniel force pushed to fix the mess I made when I merged Tophers pr.
closes #141