Adding damage plasticity model for concrete #265
Conversation
jain651
force-pushed
the
damage_plasticity_model
branch
8 times, most recently
from
1905338
to
385e47d
Compare
jain651
changed the title
jain651
force-pushed
the
damage_plasticity_model
branch
2 times, most recently
from
0ee3304
to
441b24c
Compare
jain651
force-pushed
the
damage_plasticity_model
branch
2 times, most recently
from
e59fde7
to
11167c8
Compare
jain651
changed the title
jain651
force-pushed
the
damage_plasticity_model
branch
8 times, most recently
from
0c80ffb
to
dc47ed2
Compare
|
Job Precheck on dc47ed2 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
jain651
force-pushed
the
damage_plasticity_model
branch
6 times, most recently
from
eb473ca
to
e04e29b
Compare
jain651
force-pushed
the
damage_plasticity_model
branch
4 times, most recently
from
c62ed94
to
9a7ae9a
Compare
jain651
force-pushed
the
damage_plasticity_model
branch
from
9a7ae9a
to
73fbba3
Compare
| ComputeMultipleInelasticDamageStress::computeQpJacobianMult() | ||
| { | ||
| ComputeMultipleInelasticStress::computeQpJacobianMult(); | ||
| _Jacobian_mult[_qp] = (1.0 - _D_older[_qp]) * _Jacobian_mult[_qp]; |
There was a problem hiding this comment.
Why _D_older rather than _D_old?
| _D(getMaterialProperty<Real>("elemental_damage_variable")), | ||
| _D_old(getMaterialPropertyOld<Real>("elemental_damage_variable")), | ||
| _D_older(getMaterialPropertyOlder<Real>("elemental_damage_variable")) | ||
| { |
There was a problem hiding this comment.
Would it make sense to do a dynamic_cast on the models stored in _models to enforce that they are only instances of DamagePlasticityStressUpdate?
| virtual void finalizeReturnProcess(const RankTwoTensor & rotation_increment) override; | ||
|
|
||
| private: | ||
| const Real _f_tol; |
There was a problem hiding this comment.
I hate to say this, but we should have doxygen comments describing what all the member variables and non-overwritten methods are.
| if (_zt > sqrtPhi_t / _at) | ||
| return _ft0 * pow(_zt - sqrtPhi_t / _at, (1. - _dt_bt)) * sqrtPhi_t; | ||
| else | ||
| return _ft0 * 1.E-6; |
There was a problem hiding this comment.
What's the significance of 1e-6?
|
Taken care of by #320 |
ref #184