Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated syntax in ConcreteThermalMoisture #322

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

bwspenc
Copy link
Collaborator

@bwspenc bwspenc commented Dec 21, 2022

closes #318

@moosebuild
Copy link

Job Precheck on b43b388 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/blackbear/docs/PRs/322/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format e643228e258c0d2e9dad473a06b07aeb80b49c5b

@moosebuild
Copy link

Job Test on 17a30b8 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on 17a30b8 wanted to post the following:

Coverage

8ec98b #322 17a30b
Total Total +/- New
Rate 94.28% 95.89% +1.62% 100.00%
Hits 1367 1354 -13 53
Misses 83 58 -25 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

Copy link
Collaborator

@lynnmunday lynnmunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a question but I approve

_cement_mass = isParamValid("cement_mass") ? getParam<Real>("cement_mass") : 354.0;
_water_to_cement =
isParamValid("water_to_cement_ratio") ? getParam<Real>("water_to_cement_ratio") : 0.43;
_cement_type = isParamValid("cement_type") ? getParam<MooseEnum>("cement_type") : 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need to set or check all of these defaults for the moisture_diffusivity_models?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. The way the new syntax (which we've been using for a while) works, those are all effectively required parameters for whatever model you're using. We should at least capture these recommended values, maybe just as comments in the code, so we don't lose them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up BlackBear tests to remove usage of deprecated syntax
3 participants