add test code refs #126 #291

HugoNip · 2020-03-27T14:18:32Z

test QuantificationUtils.C, FaultTreeUtils.C

HugoNip · 2020-03-27T14:26:58Z

Hello, @somu15 , I deleted the banned keywords and pulled this new request, but it still fails. Would you like to show me the error messages at this time? Thank you.

HugoNip · 2020-03-27T14:28:29Z

@somu15 , I tested this code in my PC, it works, why I still get the errors when I pull a request? Thank you.

somu15 · 2020-03-27T15:38:04Z

Please see the messages below. Are you referencing the right issue in your commits?

ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
remove the banned keywords
add new test code

ERROR: The following files contain banned keywords (std::cout, std::cerr, sleep, print_trace):
include/utils/QuantificationUtils.h
src/utils/FaultTreeUtils.C
src/utils/QuantificationUtils.C

somu15 · 2020-03-27T15:38:55Z

Also, if you'd like to know where your tests are failing, click on the failed check and login to CIVET using github (top).

cbolisetti · 2020-03-27T17:42:52Z

@HugoNip thanks for this hard work. A few comments.

MASTODON and MOOSE PRs check for more than just compilation errors (formatting, for example). So even if your compilation was successful locally, your PR may fail. Also, that doesn't mean that you need to close the PR and open a new one. You can just add another commit fixing your code according to the comments and push it to your branch and the PR will be updated automatically.
While @somu15 is correct in saying that we prefer fewer commits, currently, please focus on getting the PR to pass. We can fix the commit history later.
Also, as @somu15 mentioned, you can see where the PR errors out if you click on details and login with your GitHub credentials. I might have to add you to the MASTODON team first, so I'll do that now.
You don't need to define FaultTreeUtils, QuantificationUtils, etc., as separate classes. You can just add the methods in the various namespaces. We can talk more about this on a call next week.
As @somu15 mentioned, you have to reference an issue in your commit message. Usually, with the commit message. In your case, say something like "Added new test code. Refs Create Fault Tree Analysis Vectorpostprocessor #126" where 126 is the issue that is addressed in this PR.
Looks like another error is about using banned keywords. You cannot use them even in comments for the PR to pass. This is again an error about formatting and submitting clean code.
Lastly, a failed PR is not a bad thing at all. We submit PRs that are work in progress all the time.

HugoNip · 2020-03-27T17:51:41Z

@cbolisetti Hi, Chandu, thank you for your reply. As you say, I do use the banned keywords in comments because these parts are the printing related functions that are in the original c++ code. I think that's why the PR failed. I will remove them and try it later. Thank you very much.

cbolisetti · 2020-03-27T17:46:31Z

.vscode/settings.json

@@ -0,0 +1,8 @@
+{


Please remove this json file.

cbolisetti · 2020-03-27T17:53:07Z

include/utils/QuantificationUtils.h

+#include "FaultTreeUtils.h"
+#include "MastodonUtils.h"
+
+#define CLIP(A, MIN, MAX) (((A) < MIN) ? MIN : ((A) > MAX ? MAX : (A)))


please make this a method.

cbolisetti · 2020-03-27T17:53:29Z

include/utils/QuantificationUtils.h

+
+#define CLIP(A, MIN, MAX) (((A) < MIN) ? MIN : ((A) > MAX ? MAX : (A)))
+
+#define GEN_QUALIFICATION_R_VEC(gen, d, n, rv)                                                     \


Please make this a method as well.

cbolisetti · 2020-03-27T17:54:24Z

include/utils/QuantificationUtils.h

+      p_max = (p_max > (vec.size() - 1)) ? vec.size() : p_max;
+      return vec[p_min - 1] + ((p_i - p_min) * (vec[p_max - 1] - vec[p_min - 1]));
+    }
+    /*


this commented section is failing the PR because of the cout.

cbolisetti · 2020-03-27T17:54:37Z

include/utils/QuantificationUtils.h

+      {"NORM", NORM},
+      {"LNORM", LNORM},
+      {"PE", PE},
+      /*{"CHI_SQ"   , CHI_SQ   },*/


please remove comments

cbolisetti · 2020-03-27T17:57:18Z

src/utils/FaultTreeUtils.C

+FTAUtils::FaultTree::getRoot()
+/*!endpublic*/ { return _root; }
+
+/*!public*/


Please remove all the commented sections, eventually.

2. remove Utils.h 3. make macro #define a method 4. remove all commented sections 5. remove banned keywords

1. make macro #define a method 2. remove all commented sections 3. remove banned keywords

cbolisetti · 2020-03-30T21:20:17Z

@HugoNip please follow the directions in the above comment and that will make style changes automatically. You should then push that commit.

moosebuild · 2020-03-30T21:51:13Z

Job Precheck on 128b3d0 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/mastodon/docs/PRs/291/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 71bfd3f0b6369812bcfaa5af2c0833a611f4b1a5

moosebuild · 2020-03-30T23:54:27Z

Job Test on a94027a wanted to post the following:

View the site here

This comment will be updated on new commits.

HugoNip added 2 commits March 27, 2020 09:48

add new test code

0510b9b

remove the banned keywords

e525933

cbolisetti requested review from cbolisetti and aeslaughter March 27, 2020 17:43

cbolisetti added the Do Not Merge label Mar 27, 2020

cbolisetti reviewed Mar 27, 2020

View reviewed changes

HugoNip added 4 commits March 28, 2020 22:36

1. remove json file

4884934

2. remove Utils.h 3. make macro #define a method 4. remove all commented sections 5. remove banned keywords

remove all comments

191a4e5

Update FaultTreeUtils.C ref idaholab#126

a8204af

1. make macro #define a method 2. remove all commented sections 3. remove banned keywords

update quanticationUtils.h Ref idaholab#126

0c8e507

1. make macro #define a method 2. remove all commented sections 3. remove banned keywords

Hugo Nie added 3 commits March 30, 2020 17:44

update faultTreeUtils.C Ref idaholab#126

8a6080d

update QuantificationUtils.C

7adf618

update testFaultTreeUtils.C

128b3d0

update QuantificationUtils.C Ref idaholab#126

a94027a

HugoNip linked an issue Mar 31, 2020 that may be closed by this pull request

Create Fault Tree Analysis Vectorpostprocessor #126

Open

cbolisetti marked this pull request as draft July 14, 2020 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add test code refs #126 #291

add test code refs #126 #291

HugoNip commented Mar 27, 2020

HugoNip commented Mar 27, 2020

HugoNip commented Mar 27, 2020

somu15 commented Mar 27, 2020 •

edited

Loading

somu15 commented Mar 27, 2020

cbolisetti commented Mar 27, 2020 •

edited

Loading

HugoNip commented Mar 27, 2020

cbolisetti Mar 27, 2020

cbolisetti Mar 27, 2020

cbolisetti Mar 27, 2020

cbolisetti Mar 27, 2020

cbolisetti Mar 27, 2020

cbolisetti Mar 27, 2020

cbolisetti commented Mar 30, 2020

moosebuild commented Mar 30, 2020

moosebuild commented Mar 30, 2020


		#define CLIP(A, MIN, MAX) (((A) < MIN) ? MIN : ((A) > MAX ? MAX : (A)))

		#define GEN_QUALIFICATION_R_VEC(gen, d, n, rv) \

add test code refs #126 #291

Are you sure you want to change the base?

add test code refs #126 #291

Conversation

HugoNip commented Mar 27, 2020

HugoNip commented Mar 27, 2020

HugoNip commented Mar 27, 2020

somu15 commented Mar 27, 2020 • edited Loading

somu15 commented Mar 27, 2020

cbolisetti commented Mar 27, 2020 • edited Loading

HugoNip commented Mar 27, 2020

cbolisetti Mar 27, 2020

Choose a reason for hiding this comment

cbolisetti Mar 27, 2020

Choose a reason for hiding this comment

cbolisetti Mar 27, 2020

Choose a reason for hiding this comment

cbolisetti Mar 27, 2020

Choose a reason for hiding this comment

cbolisetti Mar 27, 2020

Choose a reason for hiding this comment

cbolisetti Mar 27, 2020

Choose a reason for hiding this comment

cbolisetti commented Mar 30, 2020

moosebuild commented Mar 30, 2020

moosebuild commented Mar 30, 2020

somu15 commented Mar 27, 2020 •

edited

Loading

cbolisetti commented Mar 27, 2020 •

edited

Loading