Some FSI additions #24204

lindsayad · 2023-04-27T20:07:09Z

Interface kernel for coupling scalar field displacments to vector fluid velocity field
Create ConvectedMeshPSPG so that we can have one-to-one comparison between INS and INSAD in the FSI module
Fix mesh convection residual for INSAD. The multiplication order needs to be switched to match the regular advection term

Closes #23680

lindsayad · 2023-04-27T20:09:32Z

@Eilloo I think the work here is relevant to some of your discussion posts as well as #23680

moosebuild · 2023-04-27T21:48:52Z

Job Documentation on fd7f724 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2023-05-01T20:20:51Z

Job Coverage on fd7f724 wanted to post the following:

Framework coverage

	a135b2	#24204 fd7f72
	Total	Total	+/-	New
Rate	85.64%	85.63%	-0.00%	0.00%
Hits	92373	92373	-	0
Misses	15494	15496	+2	4

Diff coverage report

Full coverage report

Modules coverage

Fsi

	a135b2	#24204 fd7f72
	Total	Total	+/-	New
Rate	90.48%	89.32%	-1.16%	88.17%
Hits	171	326	+155	164
Misses	18	39	+21	22

Diff coverage report

Full coverage report

Navier stokes

	a135b2	#24204 fd7f72
	Total	Total	+/-	New
Rate	84.75%	84.76%	+0.01%	98.11%
Hits	12520	12531	+11	52
Misses	2252	2253	+1	1

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

framework new line coverage rate 0.00% is less than the suggested 90.0%
fsi new line coverage rate 88.17% is less than the suggested 90.0%

This comment will be updated on new commits.

moosebuild · 2023-05-25T23:52:39Z

All jobs on c52fa14 : invalidated by @lindsayad

lindsayad · 2023-05-27T17:45:38Z

For ease of reviewing I'm going to split this into smaller chunks starting with #24514 and #24515

lindsayad · 2023-05-31T01:44:22Z

With #24515 merged, turning to #24540

github-actions · 2023-09-08T05:39:52Z

This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

lindsayad · 2023-10-10T18:35:01Z

Source would be great, but yea I agree that seems logical

moosebuild · 2023-10-10T18:59:23Z

Job LibTorch on 308ae5b : invalidated by @lindsayad

lindsayad · 2023-10-10T21:22:01Z

This now sits on top of #25574 so probably should wait for further review until that is merged

moosebuild · 2023-10-10T23:34:57Z

Job Conda (Intel Mac) on 04d15cb : invalidated by @lindsayad

- Interface kernel for coupling scalar field displacments to vector fluid velocity field - Create ConvectedMeshPSPG so that we can have one-to-one comparison between INS and INSAD in the FSI module - Fix mesh convection residual for INSAD. The multiplication order needs to be switched to match the regular advection term Closes idaholab#23680

INS and INSAD now match again

Using the relative velocity as the advecting velocity in SUPG and in calculations of tau introduced new dependence on the displacements that I don't want to spend time coding the Jacobians for

lindsayad · 2023-10-26T21:52:58Z

@maxnezdyur has reviewed this. @loganharbour, @GiudGiud, or @roystgnr could I get a CCB review when one of you has a chance?

modules/navier_stokes/include/materials/INSADTauMaterial.h

modules/navier_stokes/include/kernels/INSBase.h

modules/fsi/test/tests/2d-small-strain-transient/tests

modules/fsi/include/kernels/ConvectedMeshPSPG.h

modules/fsi/src/interfacekernels/ADPenaltyVelocityContinuity.C

- Better doxygen for ConvectedMeshPSPG - Typo fix - Better doxygen for _speed member - Inline short methods in the header - More doxygen for disp dot members in INSBase - Switch i and qp loop order Co-authored-by: Guillaume Giudicelli <[email protected]>

lindsayad · 2023-10-27T22:58:30Z

thanks for the reviews!

GiudGiud assigned lindsayad Apr 27, 2023

lindsayad force-pushed the vector-ins-convected-mesh branch 4 times, most recently from 644b376 to 8a8ed05 Compare May 1, 2023 18:22

lindsayad changed the title ~~INS/INSAD development in support of AMMT~~ [WIP] INS/INSAD development in support of AMMT May 22, 2023

lindsayad force-pushed the vector-ins-convected-mesh branch 4 times, most recently from 2cb04ed to 6787636 Compare May 24, 2023 05:15

lindsayad mentioned this pull request May 24, 2023

Not handling curvature sign switching in surface tension models in NS for laser welding #24461

Closed

lindsayad linked an issue May 24, 2023 that may be closed by this pull request

Make ALE melt pool simulations run #24462

Closed

lindsayad changed the title ~~[WIP] INS/INSAD development in support of AMMT~~ INS/INSAD development in support of AMMT May 24, 2023

lindsayad force-pushed the vector-ins-convected-mesh branch 2 times, most recently from 88eade7 to b617523 Compare May 24, 2023 21:27

lindsayad mentioned this pull request May 25, 2023

Test curvatures/ad_curvatures #12839

Closed

lindsayad force-pushed the vector-ins-convected-mesh branch 5 times, most recently from de799b1 to 082c518 Compare May 27, 2023 00:26

lindsayad mentioned this pull request May 27, 2023

Create GaussianEnergyFluxBC #24515

Merged

github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Sep 8, 2023

lindsayad force-pushed the vector-ins-convected-mesh branch from 308ae5b to 04d15cb Compare October 10, 2023 21:19

lindsayad requested a review from roystgnr as a code owner October 10, 2023 21:19

lindsayad marked this pull request as draft October 10, 2023 21:22

lindsayad added 6 commits October 17, 2023 17:40

Make FSI coverage requirement less strict

938e593

More convected -> advected language change

f59feff

Use relative velocity for SUPG velocity and tau computation

1a98e28

Modify INS to use relative velocity in SUPG/tau computations

7d89aaa

INS and INSAD now match again

Remove INS Jacobian test

165061f

Using the relative velocity as the advecting velocity in SUPG and in calculations of tau introduced new dependence on the displacements that I don't want to spend time coding the Jacobians for

lindsayad force-pushed the vector-ins-convected-mesh branch from 04d15cb to 165061f Compare October 18, 2023 00:40

Try to address Max's markdown comment

3ee3baa

lindsayad force-pushed the vector-ins-convected-mesh branch from 52effd1 to 3ee3baa Compare October 18, 2023 20:48

lindsayad marked this pull request as ready for review October 18, 2023 23:06

lindsayad requested a review from maxnezdyur October 18, 2023 23:06

maxnezdyur approved these changes Oct 19, 2023

View reviewed changes

GiudGiud reviewed Oct 27, 2023

View reviewed changes

modules/navier_stokes/include/materials/INSADTauMaterial.h Outdated Show resolved Hide resolved

GiudGiud reviewed Oct 27, 2023

View reviewed changes

lindsayad force-pushed the vector-ins-convected-mesh branch from f111b65 to 0a39b7f Compare October 27, 2023 19:59

lindsayad force-pushed the vector-ins-convected-mesh branch from 0a39b7f to fd7f724 Compare October 27, 2023 20:09

GiudGiud approved these changes Oct 27, 2023

View reviewed changes

moosebuild added the PR: Failed but allowed label Oct 27, 2023

lindsayad merged commit f1b7bfa into idaholab:next Oct 27, 2023
43 checks passed

lindsayad deleted the vector-ins-convected-mesh branch October 27, 2023 22:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some FSI additions #24204

Some FSI additions #24204

lindsayad commented Apr 27, 2023 •

edited

Loading

lindsayad commented Apr 27, 2023

moosebuild commented Apr 27, 2023 •

edited

Loading

moosebuild commented May 1, 2023 •

edited

Loading

moosebuild commented May 25, 2023

lindsayad commented May 27, 2023

lindsayad commented May 31, 2023

github-actions bot commented Sep 8, 2023

lindsayad commented Oct 10, 2023

moosebuild commented Oct 10, 2023

lindsayad commented Oct 10, 2023

moosebuild commented Oct 10, 2023

lindsayad commented Oct 26, 2023

lindsayad commented Oct 27, 2023

Some FSI additions #24204

Some FSI additions #24204

Conversation

lindsayad commented Apr 27, 2023 • edited Loading

lindsayad commented Apr 27, 2023

moosebuild commented Apr 27, 2023 • edited Loading

moosebuild commented May 1, 2023 • edited Loading

Framework coverage

Modules coverage

Fsi

Navier stokes

Full coverage reports

Warnings

moosebuild commented May 25, 2023

lindsayad commented May 27, 2023

lindsayad commented May 31, 2023

github-actions bot commented Sep 8, 2023

lindsayad commented Oct 10, 2023

moosebuild commented Oct 10, 2023

lindsayad commented Oct 10, 2023

moosebuild commented Oct 10, 2023

lindsayad commented Oct 26, 2023

lindsayad commented Oct 27, 2023

lindsayad commented Apr 27, 2023 •

edited

Loading

moosebuild commented Apr 27, 2023 •

edited

Loading

moosebuild commented May 1, 2023 •

edited

Loading