Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Cardinal model of a 7-Pin LFR demonstration case #360

Merged
merged 26 commits into from
Sep 26, 2024
Merged

Adding Cardinal model of a 7-Pin LFR demonstration case #360

merged 26 commits into from
Sep 26, 2024

Commits on Sep 24, 2024

  1. fix reference warnings related to PhysorANL and ArgonneReport

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9f7fb0b View commit details
    Browse the repository at this point in the history

  2. add cardinal 7pin model WIP

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    557aeb6 View commit details
    Browse the repository at this point in the history

  3. add refs to MSRE reactivity insertion test with SAM

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b392036 View commit details
    Browse the repository at this point in the history

  4. add description of HC.i

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c2a9808 View commit details
    Browse the repository at this point in the history

  5. add Cardinal input description

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1e233bc View commit details
    Browse the repository at this point in the history

  6. md file added

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ade28c2 View commit details
    Browse the repository at this point in the history

  7. update acknowledgement

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8140504 View commit details
    Browse the repository at this point in the history

  8. add extra description of mesh generation from input files

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c285ac8 View commit details
    Browse the repository at this point in the history

  9. add extra description of nekRS case files

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7ff0863 View commit details
    Browse the repository at this point in the history

  10. addressed Hansols review comments

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d69e8ef View commit details
    Browse the repository at this point in the history

  11. clean the input files and add tests

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1c3e16c View commit details
    Browse the repository at this point in the history

  12. add nekrs mesh and IC files and Griffin cross section file via git lfs

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    76638f8 View commit details
    Browse the repository at this point in the history

  13. addition of cardinal SFR model idaholab#359

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b1ac7b2 View commit details
    Browse the repository at this point in the history

  14. remove white trailing spaces from mesh input files

    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7690e6a View commit details
    Browse the repository at this point in the history

  15. address 1st round feedback from Guillaume 

    Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>

Update doc/content/lfr/cardinal_7pincell/Cardinal_7pin_LFR_demo.md

Co-authored-by: Guillaume Giudicelli <[email protected]>
    @hapfang @GiudGiud
    hapfang and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7aab50c View commit details
    Browse the repository at this point in the history

  16. change module name from HC to HT 

    address feedback of Guillaume round 2
    @hapfang @GiudGiud
    hapfang authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    789a04d View commit details
    Browse the repository at this point in the history

  17. Misc changes 

    - enable using the meshing output files
- enable using the HC input directly
    @GiudGiud
    GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cb52d67 View commit details
    Browse the repository at this point in the history

  18. Address Guillaume's comment to assign block names using RenameBlockGe… 

    …nerator
    @HansolPark1 @GiudGiud
    HansolPark1 authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    522290a View commit details
    Browse the repository at this point in the history

  19. Convert heat flux variable in MOOSE heat conduction from elemental ty… 

    …pe to nodal type for transfer using ProjectionAux
    @HansolPark1 @GiudGiud
    HansolPark1 authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ae17991 View commit details
    Browse the repository at this point in the history

  20. Address Guillaume's comment to update doc

    @HansolPark1 @GiudGiud
    HansolPark1 authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9bd5ad6 View commit details
    Browse the repository at this point in the history

  21. Have heat flux variables block restricted to the solid region to avoi… 

    …d being halved when being projected to nodal value
    @HansolPark1 @GiudGiud
    HansolPark1 authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    30320a2 View commit details
    Browse the repository at this point in the history

  22. Better initial condition for heat conduction calculation which is for… 

    … running HC.i standalone
    @HansolPark1 @GiudGiud
    HansolPark1 authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3e3f63e View commit details
    Browse the repository at this point in the history

  23. Change RunApp test to CSVDiff

    @HansolPark1 @GiudGiud
    HansolPark1 authored and GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    22db5bc View commit details
    Browse the repository at this point in the history

  24. Address Guillaume review 

    - add testing with more apps
- add headers to simulation inputs

Update lfr/7pin_cardinal_demo/runjob_sawtooth.sh

Update lfr/7pin_cardinal_demo/runjob_sawtooth.sh

Bring back delete fls file
    @GiudGiud
    GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f00e827 View commit details
    Browse the repository at this point in the history

  25. Fix meshing tests 

    Add gold files in the right folder
use Newton for HC solve for performance
    @GiudGiud
    GiudGiud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    160faeb View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add neutronics-only test for 7 pin model

    @GiudGiud
    GiudGiud committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6d85ed0 View commit details
    Browse the repository at this point in the history