Temporary solution to make the test pass with use_legacy_initial_residual_evaluation_bahavior=false #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dual_evaluation_bahavior flag off idaholab#379
GiudGiud
approved these changes
Apr 15, 2024
|
Job VTB Documentation on c6bcaec wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Test griffin on c6bcaec : invalidated by @YaqiWang |
1 similar comment
|
Job Test griffin on c6bcaec : invalidated by @YaqiWang |
|
@GiudGiud do you think we can merge this? I have no idea why we still have that griffin test failure and the pronghorn failure. But I think they are irrelevant with my change here. We really need to remove that legacy note before the workshop. |
|
we might have to allow things to fail temporarily to get it propagated |
|
Thanks @GiudGiud! |
GiudGiud
added
the
model_maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #379.