Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve documentation of normalization methods for laplacian_matrix() #1420

Merged
merged 1 commit into from
Jul 2, 2024
Merged

docs: improve documentation of normalization methods for laplacian_matrix() #1420

merged 1 commit into from
Jul 2, 2024

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jul 2, 2024

Fix #1384

@maelle maelle requested a review from szhorvat July 2, 2024 10:27
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Jul 2, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

szhorvat
szhorvat requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@szhorvat szhorvat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maëlle! Let me merge these suggestions quickly and test them locally.

R/structural.properties.R Outdated Show resolved Hide resolved
R/structural.properties.R Outdated Show resolved Hide resolved
R/structural.properties.R Outdated Show resolved Hide resolved
R/structural.properties.R Outdated Show resolved Hide resolved
R/structural.properties.R Outdated Show resolved Hide resolved
R/structural.properties.R Outdated Show resolved Hide resolved
@szhorvat
Copy link
Member

szhorvat commented Jul 2, 2024 •
edited
Loading

Alright, now it looks good. Please have a look at the comment I made about \eqn and LaTeX above. I think it's good to go now. Let me know if you want me to manually squash that ugly series of commits.

image

@maelle
Copy link
Contributor Author

maelle commented Jul 2, 2024

Thank you!! Yes, squashing before adding the merge-queue label would be perfect. 🙏

@aviator-app aviator-app bot merged commit d1665e6 into main Jul 2, 2024
11 checks passed
@aviator-app aviator-app bot deleted the laplacian-docs branch July 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szhorvat szhorvat szhorvat approved these changes

Assignees
No one assigned
Labels
mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve laplacian_matrix docs
2 participants
@maelle @szhorvat