Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename test file to align with script structure.info.R #1421

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jul 2, 2024

Really minimal.

@szhorvat for info part of the refactoring of tests will consist in aligning script names and test filenames because this allows to easily jump from test to script and vice versa (using usethis::use_r() and usethis::use_test()).

Copy link
Contributor

aviator-app bot commented Jul 2, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Member

szhorvat commented Jul 2, 2024

If I understand you correctly, you are asking me to follow certain naming standards. I'm happy to do so but I have a lot of trouble keeping these in my head (even things I came up with myself). Could you please open a new wiki page and write down (very briefly) the standards we need to follow? I can then refer to that, and I don't need to remember anything by heart :-)

We do the same in the C core (see e.g. here and here).

@aviator-app aviator-app bot merged commit ad3f0ec into main Jul 2, 2024
11 checks passed
@aviator-app aviator-app bot deleted the adj branch July 2, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants