feat(server): country geocoding for remote locations #10950
Merged
+137
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
force-pushed
the
feat/remote-location-geocoding
branch
from
f97d14d
to
9b0e9a8
Compare
zackpollard
changed the title
danieldietzler
force-pushed
the
feat/remote-location-geocoding
branch
from
203d1f3
to
9b20af2
Compare
danieldietzler
force-pushed
the
feat/remote-location-geocoding
branch
from
9b20af2
to
96a7dbb
Compare
danieldietzler
force-pushed
the
feat/remote-location-geocoding
branch
from
4fa7d0d
to
c6920f5
Compare
jrasm91
reviewed
Jul 18, 2024
| @@ -134,7 +138,29 @@ export class MapRepository implements IMapRepository { | |||
| this.logger.warn( | |||
| `Response from database for reverse geocoding latitude: ${point.latitude}, longitude: ${point.longitude} was null`, | |||
| ); | |||
| return null; | |||
|
|
|||
| const ne_response = await this.naturalEarthCountriesRepository | |||
There was a problem hiding this comment.
We should change the above condition to return if it has a response. Then, de-indent all of this.
There was a problem hiding this comment.
I updated the code. Definitely makes it clearer!
danieldietzler
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add country reverse geocoding in case city geocoding is null. Uses country boundaries from Natural Earth
Dependencies
base-images PR: immich-app/base-images#80
Database changes:
Server changes:
Note - this uses the current geocoding state metadata for DB import
Web UI changes: