Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update account AUP signature time via API #608

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Update account AUP signature time via API #608

merged 7 commits into from
Jul 21, 2023

Conversation

rmiccoli
Copy link
Contributor

No description provided.

@rmiccoli rmiccoli mentioned this pull request May 29, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@enricovianello enricovianello linked an issue Jul 11, 2023 that may be closed by this pull request
Updating account AUP with API #603
Closed
@giacomini giacomini marked this pull request as draft July 11, 2023 12:25
@federicaagostini
Copy link
Contributor

Also the authorization on the /iam/api/signature endpoint (for POST/GET requests) can rely only on the #iam.hasDashboardRole('ROLE_USER') since you need an authenticated user.

@rmiccoli
Add changes
ba0f355 
- when aup signature is present, update the signature time
- when aup signature is not present, create it
- when account is not found, return 404 not 500
- fix authorization to access iam/aup/signature api
@rmiccoli
Increase coverage
459017d
@rmiccoli
Change PUT in PATCH
6bf25c4
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@enricovianello enricovianello marked this pull request as ready for review July 21, 2023 13:26
@enricovianello enricovianello merged commit ed197ea into develop Jul 21, 2023
5 checks passed
@enricovianello enricovianello deleted the issue-603-bis branch July 24, 2023 19:04
@rmiccoli rmiccoli changed the title Update account AUP via API Update account AUP signature time via API Sep 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicaagostini federicaagostini Awaiting requested review from federicaagostini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating account AUP with API
3 participants
@rmiccoli @federicaagostini @enricovianello