Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ZTC and ZRC OpenApi specs implemented by OpenZaak 1.13.0 #1346

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

edgarvonk
Copy link
Member

Updated the ZGW ZTC and ZRC OpenApi specs as implemented by OpenZaak 1.13.0 so we are up to date and so that we can use new functionality provided by these new ZGW APIs. Had to manually change the ZRC and ZTC OpenAPI spec YAML files as temporary fix for open-zaak/open-zaak#1699, for: OpenAPITools/openapi-generator#18951 and for OpenAPI Generator not yet supporting oneOf.

Solves PZ-1390

@edgarvonk edgarvonk requested review from hsiliev, felixcicatt and a team as code owners June 27, 2024 08:56
Copy link
Contributor

unit-test-results

 42 files  ±0   66 suites  ±0   1m 41s ⏱️ -1s
218 tests ±0  217 ✅ ±0  1 💤 ±0  0 ❌ ±0 
258 runs  ±0  256 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit cf77d13. ± Comparison against base commit f545f69.

Copy link
Contributor

integration-test-results

16 files  ±0  16 suites  ±0   20s ⏱️ -1s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
62 runs  ±0  62 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cf77d13. ± Comparison against base commit f545f69.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 44.64286% with 31 lines in your changes missing coverage. Please review.

Project coverage is 42.85%. Comparing base (f545f69) to head (cf77d13).

Files Patch % Lines
...n/converter/RESTInformatieobjecttypeConverter.java 0.00% 8 Missing ⚠️
...java/net/atos/client/zgw/shared/ZGWApiService.java 50.00% 4 Missing and 1 partial ⚠️
...atos/client/zgw/zrc/util/RolJsonbDeserializer.java 50.00% 2 Missing and 1 partial ⚠️
...a/net/atos/zac/healthcheck/HealthCheckService.java 0.00% 3 Missing ⚠️
...os/zac/productaanvraag/ProductaanvraagService.java 50.00% 3 Missing ⚠️
.../kotlin/net/atos/zac/app/taken/TakenRESTService.kt 0.00% 3 Missing ⚠️
.../app/zaken/converter/RESTResultaattypeConverter.kt 33.33% 0 Missing and 2 partials ⚠️
.../atos/client/zgw/zrc/model/ZaakListParameters.java 0.00% 0 Missing and 1 partial ⚠️
...ac/signalering/event/SignaleringEventObserver.java 50.00% 0 Missing and 1 partial ⚠️
...atos/client/zgw/ztc/model/RoltypeListParameters.kt 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1346      +/-   ##
============================================
- Coverage     42.86%   42.85%   -0.02%     
  Complexity     2426     2426              
============================================
  Files           934      934              
  Lines         18795    18795              
  Branches       1323     1320       -3     
============================================
- Hits           8056     8054       -2     
- Misses        10109    10111       +2     
  Partials        630      630              
Flag Coverage Δ
integrationtests 40.89% <37.50%> (-0.02%) ⬇️
unittests 21.91% <14.28%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarvonk edgarvonk added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 0b2a7c6 Jun 27, 2024
22 checks passed
@edgarvonk edgarvonk deleted the feature/PZ-1390-update-ztc-and-zrc-openapi-specs branch June 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants