Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github actions #82

Merged
merged 2 commits into from
Nov 6, 2020
Merged

add github actions #82

merged 2 commits into from
Nov 6, 2020

Conversation

IsabellaDev
Copy link

@IsabellaDev IsabellaDev commented Nov 2, 2020

Signed-off-by: isabellaliu [email protected]

Description

Add github action support

How Has This Been Tested?

I have tested it in my own repo.

How are existing users impacted? What migration steps/scripts do we need?

No code changed, only the github action.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Signed-off-by: isabellaliu <[email protected]>
@derek derek bot added the new-contributor label Nov 2, 2020
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: isabellaliu <[email protected]>
@IsabellaDev
Copy link
Author

Hi Alex:
I have done the changes, Any problem, please let me know.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 220055f into inlets:master Nov 6, 2020
@alexellis
Copy link
Member

Thank you @isabellaliu77 this looks good.

We actually have many more projects to migrate too and are co-ordinating on OpenFaaS Slack, you are welcome to join the #contributors channel there.

openfaas/faas#1585

https://slack.openfaas.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants