Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Masternode Setup Script #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Masternode Setup Script #165

wants to merge 1 commit into from

Conversation

FornaxA
Copy link
Collaborator

@FornaxA FornaxA commented Jun 14, 2019

  • Point to the latest release
  • Correct naming and URL
  • Abstract from compression tpye

@FornaxA FornaxA self-assigned this Jun 14, 2019
@FornaxA FornaxA added the Bug Something isn't working label Jun 14, 2019
MitchellCash
MitchellCash approved these changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@MitchellCash MitchellCash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

ckti
ckti requested changes Jun 19, 2019
View reviewed changes
Copy link
Collaborator

@ckti ckti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of other changes needed to get this script working properly, icanhasip.com no longer works correctly and needs to change to
NODEIP=$(curl https://ipinfo.io/ip) (or some other site that gives back an external IP)
as it needs an external ip for ioncoin.conf
I'm not sure we need the download and build from source functionality as this will only build on 16.04 and we're at 19.04.?
grabbing the latest gitian release is all it needs to do or give a choice of download release or build from source?

@ioncoincore ioncoincore added the help wanted Extra attention is needed label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckti ckti ckti approved these changes

@MitchellCash MitchellCash MitchellCash approved these changes

@CeForce CeForce Awaiting requested review from CeForce

@ioncoincore ioncoincore Awaiting requested review from ioncoincore

@ionwolverine ionwolverine Awaiting requested review from ionwolverine

Assignees

@FornaxA FornaxA

Labels
Bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FornaxA @ckti @MitchellCash @ioncoincore