Add minimum rust version #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chipshort, sorry for the slow reply, I've been very busy over the last few weeks. Yes, this is a good idea, I will add this to the next version (v0.9.1). I'll just edit this PR to merge into the v0.9.1 branch first, which I'll then merge into the master branch (because the master branch always contains the code for the latest version). |
|
v0.9.1 just published now, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, are you interested in adding the minimum rust version to
Cargo.toml?That way people with a dependency on the crate (direct or transitive) get an error message that is a bit more helpful.
Currently, if you compile with pre-1.65 Rust, you just get a bunch of errors like this:
Only downside is that it has to be kept in sync with the code to be useful.