Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformIO and some refactors #12

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

jvegaf
Copy link

@jvegaf jvegaf commented Apr 1, 2022

Hi,

I've migrated the Arduino project to PlatformIO because its more feats like:

  • deps management more easy, with automatic downloads and updates
  • no plugin needed to upload the data folder ( we have a task ), it's explained in the README.
  • have a power linter tool that helps to avoid have bugs in the code....

image


test with my nodemcu board is working perfect 😄
image

Coming soon will like send a some PR with more little refactors

Regards

@jvegaf jvegaf marked this pull request as draft April 3, 2022 12:10
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
@jvegaf jvegaf changed the title PlatformIO PlatformIO and some refactors Apr 4, 2022
@jvegaf jvegaf marked this pull request as ready for review April 4, 2022 18:55
@jvegaf
Copy link
Author

jvegaf commented Apr 4, 2022

Sorry, I forget extract in other branch the code refactors, even so I did testing and commit each little change for avoid broke nothing.

The main reason of this refactors is separate responsibilities in different modules, making this great project more testable and robust, so that will be more easy add new features.

@issalig
Copy link
Owner

issalig commented Apr 6, 2022

Hi, thanks for your work. It is nice to see other people collaborating.
I'm busy these days but I will take a look as soon as possible.
Is it possible to have the code for Arduino IDE and PlatformIO? Last time I tried PlatformIO I had to change .ino extensions and some other things but I would like to have it working for both frameworks.

@jvegaf
Copy link
Author

jvegaf commented Apr 6, 2022

I'll look at a way to make it compatible with both environments.

in my case when l tried platformIO didn't feel like back to arduino.

@jvegaf
Copy link
Author

jvegaf commented Apr 6, 2022

I found the solution 🚀🚀🚀

now works with both environments.

compiled with Arduino 👇🏻

image

Hack for can works with Arduino IDE and PlatformIO at the same time

Also documented

Signed-off-by: Jose Vega <[email protected]>
@issalig
Copy link
Owner

issalig commented Apr 7, 2022

Great. I will take a look asap

@issalig
Copy link
Owner

issalig commented Apr 15, 2022

Sorry, still no time.

@jvegaf
Copy link
Author

jvegaf commented Apr 16, 2022

Sorry, still no time.

Don't worry friend, that's things happen to everybody. Trust me, I prefer that you take it with calm because you better understand the changes that I propose you.

Now I am doing a few changes to the PCB for achieve works with a NodeMCU board (I have many of this boards forgotten in a drawer 😄 ).

I will make a pcb piece when I end the changes to continue playing with the project.

@snetekombinerke
Copy link

Hi, Is is possible to get finished pcb?

@issalig
Copy link
Owner

issalig commented Aug 23, 2022

Hi @snetekombinerke , if you are interested in my version for wemos d1 mini write me at [email protected] for more details about getting the pcb. If it is the nodeMCU, just contact jvegaf.

@jvegaf
Copy link
Author

jvegaf commented Aug 26, 2022

Hi @snetekombinerke , if you are interested in my version for wemos d1 mini write me at [email protected] for more details about getting the pcb. If it is the nodeMCU, just contact jvegaf.

@issalig @snetekombinerke just I released the esp32 pcb version 😁

https://github.com/jvegaf/toshiba_air_cond/releases/tag/esp32_v1

airpcb_smd_board

airpcb_smd_top

airpcb_smd_bottom

@issalig
Copy link
Owner

issalig commented Aug 26, 2022

Nice!

@jvegaf, BTW I wrote you an email to your gmail some weeks ago, not sure if you got it.

@jvegaf
Copy link
Author

jvegaf commented Aug 26, 2022

Nice!

@jvegaf, BTW I wrote you an email to your gmail some weeks ago, not sure if you got it.

I've searched in my gmail but I doesn't found it.

@issalig can you resend me it again ?

Thanks

@issalig
Copy link
Owner

issalig commented Aug 27, 2022

Is josevega234 correct? it is where I sent it.

@jvegaf
Copy link
Author

jvegaf commented Aug 27, 2022

I sended you a email to your mejijof at getnada dot com account

@issalig
Copy link
Owner

issalig commented Aug 27, 2022

Ok. Got it.

@jvegaf
Copy link
Author

jvegaf commented Aug 28, 2022

I replied your mail 😊

@snetekombinerke
Copy link

Hi, I've sent you an email 30. avg., 21:39. Please check.

@jvegaf
Copy link
Author

jvegaf commented Oct 11, 2022 via email

@obvious-creations
Copy link

Hi @jvegaf, was just wondering how far did you get this? I was looking out for solutions for our Toshiba air conditioner units and stumbled across this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants