add an ability to create serverless elasticache redis, add examples #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plain5
requested changes
Mar 25, 2024
examples/memcache/terragrunt.hcl
Outdated
There was a problem hiding this comment.
examples/serverless/terragrunt.hcl
Outdated
| @@ -90,7 +90,7 @@ resource "aws_security_group_rule" "this_egress_source" { | |||
| # --------------------------------------------------------------------------------------------------------------------- | |||
|
|
|||
| resource "aws_elasticache_subnet_group" "this" { | |||
| count = var.create_subnet_group ? 1 : 0 | |||
| count = var.cache_type == "traditional" && var.create_subnet_group ? 1 : 0 | |||
There was a problem hiding this comment.
- There is no reason to set
cache_typehere.
Comment on lines
+113
to
+115
| for_each = var.cluster_mode_enabled ? concat([ | ||
| { name = "cluster-enabled", value = "yes" } | ||
| ], var.parameter) : var.parameter |
There was a problem hiding this comment.
- It's not convenient. Return to the one line.
Comment on lines
+150
to
+152
| preferred_cache_cluster_azs = length(var.preferred_cache_cluster_azs) == 0 ? null : [ | ||
| for n in range(0, var.num_cache_clusters) : element(var.preferred_cache_cluster_azs, n) | ||
| ] |
There was a problem hiding this comment.
- It's not convenient. Return to the one line.
| default = 10000 | ||
| } | ||
|
|
||
| variable "serverless_tags" { |
| description = "Address of the endpoint for the reader node in the replication group." | ||
| } | ||
| # --------------------------------------------------------------------------------------------------------------------- | ||
| # ElastiCache Endpoint Serverless |
| @@ -395,6 +402,32 @@ variable "transit_encryption_enabled" { | |||
| EOT | |||
| } | |||
|
|
|||
| # Serverless-specific variables | |||
There was a problem hiding this comment.
ElastiCache Serverless. Also, add proper formatting(# ----\n# TEXT\n# ----).
Comment on lines
+406
to
+430
|
|
||
|
|
||
| variable "name" { | ||
| description = "Name for serverless cache." | ||
| type = string | ||
| default = null | ||
| } | ||
|
|
||
| variable "data_storage_maximum" { | ||
| description = "Maximum data storage for serverless cache." | ||
| type = number | ||
| default = 50 | ||
| } | ||
|
|
||
| variable "ecpu_per_second_maximum" { | ||
| description = "Maximum ECPU units per second for serverless cache." | ||
| type = number | ||
| default = 10000 | ||
| } | ||
|
|
||
| variable "serverless_tags" { | ||
| description = "Tags for serverless cache." | ||
| type = map(any) | ||
| } | ||
|
|
There was a problem hiding this comment.
-
It's easier and better to take variables description from Documentation.
-
Format should be :
type
default
description
| @@ -200,3 +204,28 @@ resource "aws_elasticache_replication_group" "this" { | |||
| aws_security_group.this | |||
| ] | |||
| } | |||
|
|
|||
| resource "aws_elasticache_serverless_cache" "serverless" { | |||
There was a problem hiding this comment.
resource "aws_elasticache_serverless_cache" "this" {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.