Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move auv_logger and auv_cam #15

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

canerdev
Copy link

@canerdev canerdev commented Apr 30, 2024

#3
created the necessary folders and moved the auv_logger and auv_cam from auv-software-legacy to corresponding folders in the auv-software

update #1 -> fixed the directory structure. added the expressed directives in docker build file.

@senceryazici
Copy link
Member

Installing the cv_bridge package via apt on the jetson breaks up locally installed opencv for some reason. We need to tell the rosdep to ignore the requirement for cv_bridge, just like in previous docker build file here

@senceryazici
Copy link
Member

start with adding

        --skip-keys=libopencv-dev \
        --skip-keys=cv_bridge \

directives for rosdep in docker build file.

This can mess up the desktop build as well since cv_bridge is meant to be installed on a native desktop system. Lets see if CI fails.

@senceryazici
Copy link
Member

Also let's follow directory structure in #7. auv_cam will go under auv_hardware

@senceryazici
Copy link
Member

@canerdev Hello :D

@canerdev
Copy link
Author

@senceryazici su siralar yogunum biraz. ilgilenecegim.

@@ -18,4 +18,6 @@ RUN apt-get update && \
ros-noetic-xacro \
ros-noetic-robot-localization && \
rm -rf /var/lib/apt/lists/*

rosdep install \
Copy link
Member

@senceryazici senceryazici May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be before rm -rf /var/lib/apt/lists line

Also after each command do not forget '&& ' instead of ''

Correct version should be

rosdep ... \
  --skip-keys ... \
  --skip-keys ... && \
rm -rf /var/...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@canerdev
Copy link
Author

@senceryazici any updates?

@senceryazici
Copy link
Member

It seems here there is a better way to record topics with regular expressions. Let's remove the auv_logger changes from this PR, and convert it to single auv_cam

@canerdev
Copy link
Author

canerdev commented Jun 5, 2024

It seems here there is a better way to record topics with regular expressions. Let's remove the auv_logger changes from this PR, and convert it to single auv_cam

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants