Skip to content

Commit

Permalink
Changed V2 to accept OTEL's Telset
Browse files Browse the repository at this point in the history
Signed-off-by: Wise-Wizard <[email protected]>
  • Loading branch information
Wise-Wizard committed Jul 4, 2024
1 parent 3ec9594 commit 0002dc6
Showing 1 changed file with 15 additions and 14 deletions.
29 changes: 15 additions & 14 deletions cmd/jaeger/internal/extension/jaegerquery/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import (

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/extension"
"go.opentelemetry.io/otel/trace"
"go.uber.org/zap"

"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/jaegerstorage"
queryApp "github.com/jaegertracing/jaeger/cmd/query/app"
"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
"github.com/jaegertracing/jaeger/pkg/jtracer"
"github.com/jaegertracing/jaeger/pkg/telemetery"
"github.com/jaegertracing/jaeger/pkg/tenancy"
"github.com/jaegertracing/jaeger/plugin/metrics/disabled"
Expand All @@ -28,16 +28,19 @@ var (
)

type server struct {
config *Config
logger *zap.Logger
server *queryApp.Server
jtracer *jtracer.JTracer
config *Config
logger *zap.Logger
server *queryApp.Server
tracer trace.TracerProvider
hcFunc func(*component.StatusEvent)
}

func newServer(config *Config, otel component.TelemetrySettings) *server {
return &server{
config: config,
logger: otel.Logger,
tracer: otel.TracerProvider,
hcFunc: otel.ReportStatus,
}
}

Expand Down Expand Up @@ -75,17 +78,15 @@ func (s *server) Start(_ context.Context, host component.Host) error {
// TODO OTel-collector does not initialize the tracer currently
// https://github.com/open-telemetry/opentelemetry-collector/issues/7532
//nolint
s.jtracer, err = jtracer.New("jaeger")

if err != nil {
return fmt.Errorf("could not initialize a tracer: %w", err)
}
statusReporter := func(ev *component.StatusEvent) {
s.logger.Info("OTLP receiver status change", zap.Stringer("status", ev.Status()))
}

telset := telemetery.Setting{
Logger: s.logger,
TracerProvider: s.jtracer.OTEL,
ReportStatus: statusReporter,
TracerProvider: s.tracer,
ReportStatus: s.hcFunc,
}
// TODO contextcheck linter complains about next line that context is not passed. It is not wrong.
//nolint
Expand Down Expand Up @@ -140,8 +141,8 @@ func (s *server) Shutdown(ctx context.Context) error {
if s.server != nil {
errs = append(errs, s.server.Close())
}
if s.jtracer != nil {
errs = append(errs, s.jtracer.Close(ctx))
}
// if s.tracer != nil {
// errs = append(errs, s.tracer.Shutdown(ctx))
// }
return errors.Join(errs...)
}

0 comments on commit 0002dc6

Please sign in to comment.