-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SPM in Jaeger v2 #5681
base: main
Are you sure you want to change the base?
Enable SPM in Jaeger v2 #5681
Conversation
Signed-off-by: FlamingSaint <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 329 329
Lines 16060 16061 +1
=======================================
+ Hits 15479 15480 +1
Misses 404 404
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly advice including integration test in this PR, since we already have it for v1. This would be the best proof that the setup works.
Signed-off-by: FlamingSaint <[email protected]>
Okay. I will start working on adding the e2e test for v2. |
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, but CI for v2 failed. Please test it locally first, it's fairly quick.
time="2024-06-28T00:59:22Z" level=warning msg="/home/runner/work/jaeger/jaeger/docker-compose/monitor/docker-compose-v2.yml: `version` is obsolete"
jaeger-1 | 2024/06/28 00:54:31 application version: git-commit=250261fca3c21d70178ee896353c4c50e971c725, git-version=v1.58.0, build-date=2024-06-28T00:52:08Z
jaeger-1 | Error: failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:
jaeger-1 |
jaeger-1 | * error decoding 'exporters': unknown type: "prometheus" for id: "prometheus" (valid values: [otlphttp jaeger_storage_exporter kafka debug otlp])
jaeger-1 | 2024/06/28 00:54:31 failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:
jaeger-1 |
jaeger-1 | * error decoding 'exporters': unknown type: "prometheus" for id: "prometheus" (valid values: [otlphttp jaeger_storage_exporter kafka debug otlp])
Signed-off-by: FlamingSaint <[email protected]>
TODO: Still need to fix the error that microsim is throwing. Not sure what is causing it microsim-1 | 2024/06/28 05:19:58 Post "http://localhost:14278/api/traces": dial tcp [::1]:14278: connect: connection refused |
Which problem is this PR solving?
Description of the changes
How was this change tested?
make dev-v2
insidedocker-compose/monitor
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test