Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka exporter and receiver configuration #5703

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

joeyyy09
Copy link
Member

@joeyyy09 joeyyy09 commented Jul 3, 2024

Which problem is this PR solving?

Description of the changes

  • Add config files for replacement of jaeger-collector and jaeger-ingester.
  • Add the architecture for the integration tests for kafka.
  • Add e2e integration tests for Kafka.

How was this change tested?

  • Manually ran the collector, ingester configs to check if the data is being pushed and pulled the right way and verified the architecture.

Checklist

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (813ff32) to head (4d4a882).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5703      +/-   ##
==========================================
- Coverage   96.66%   96.65%   -0.02%     
==========================================
  Files         341      341              
  Lines       16451    16451              
==========================================
- Hits        15902    15900       -2     
- Misses        361      362       +1     
- Partials      188      189       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.77% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.03% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.90% <ø> (+0.01%) ⬆️
grpc_v1 9.52% <ø> (+0.01%) ⬆️
grpc_v2 7.47% <ø> (ø)
kafka 9.74% <ø> (ø)
memory_v2 1.88% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.89% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.90% <ø> (+0.01%) ⬆️
unittests 95.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but we need e2e tests

@yurishkuro yurishkuro added storage/kafka v2 changelog:exprimental Change to an experimental part of the code labels Jul 3, 2024
@joeyyy09
Copy link
Member Author

joeyyy09 commented Jul 4, 2024

Lgtm, but we need e2e tests

Yeah, will get started on it!

Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
cmd/jaeger/internal/integration/kafka_test.go Outdated Show resolved Hide resolved
cmd/jaeger/internal/integration/kafka_test.go Outdated Show resolved Hide resolved
cmd/jaeger/internal/integration/kafka_test.go Outdated Show resolved Hide resolved
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Harshith Mente <[email protected]>
joeyyy09 and others added 7 commits July 19, 2024 09:29
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Harshith Mente <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Harshith Mente <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
@@ -23,7 +23,7 @@ func TestBadgerStorage(t *testing.T) {
GetOperationsMissingSpanKind: true,
},
}
s.e2eInitialize(t, "badger")
s.e2eInitialize(t, "badger", true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do this differently

  • name the parameter such that its default value (false) works for almost every test, such that you only override it for Kafka
  • define that parameter in the struct, not in the function. You can see above GetOperationsMissingSpanKind is an example of parameter that affects how the tests execute.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay will work on this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced a new parameter SkipStorageCleaner inside the E2EStorageIntegration which is by default false. So all the other tests work fine. We'll be overriding it only for the Kafka collector config so we that we dont inject the storage cleaner extension. I'd done this in my latest fix, let me know if this is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/kafka v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jaeger v2] Add Kafka exporter and receiver
2 participants