-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kafka exporter and receiver configuration #5703
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: joeyyy09 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5703 +/- ##
==========================================
- Coverage 96.66% 96.65% -0.02%
==========================================
Files 341 341
Lines 16451 16451
==========================================
- Hits 15902 15900 -2
- Misses 361 362 +1
- Partials 188 189 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but we need e2e tests
Yeah, will get started on it! |
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Harshith Mente <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Harshith Mente <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Harshith Mente <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
@@ -23,7 +23,7 @@ func TestBadgerStorage(t *testing.T) { | |||
GetOperationsMissingSpanKind: true, | |||
}, | |||
} | |||
s.e2eInitialize(t, "badger") | |||
s.e2eInitialize(t, "badger", true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do this differently
- name the parameter such that its default value (false) works for almost every test, such that you only override it for Kafka
- define that parameter in the struct, not in the function. You can see above
GetOperationsMissingSpanKind
is an example of parameter that affects how the tests execute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay will work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduced a new parameter SkipStorageCleaner
inside the E2EStorageIntegration
which is by default false. So all the other tests work fine. We'll be overriding it only for the Kafka collector config so we that we dont inject the storage cleaner extension. I'd done this in my latest fix, let me know if this is fine
Signed-off-by: joeyyy09 <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test