Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add github workflow for nitro node #424

Closed
wants to merge 7 commits into from
Closed

ci: Add github workflow for nitro node #424

wants to merge 7 commits into from

Conversation

InNoobWeTrust
Copy link
Contributor

@InNoobWeTrust InNoobWeTrust commented Feb 6, 2024 •
edited
Loading

This is a successor of #367

  • Fix bug not being able to spawn nitro process on Windows
  • Add CI workflows for nitro-node

@InNoobWeTrust InNoobWeTrust marked this pull request as ready for review February 21, 2024 07:40
@InNoobWeTrust InNoobWeTrust marked this pull request as draft February 22, 2024 10:48
@InNoobWeTrust InNoobWeTrust force-pushed the feat/workflow-for-nitro-node branch 10 times, most recently from e6d5f7a to 28acd27 Compare February 23, 2024 10:00
@InNoobWeTrust InNoobWeTrust force-pushed the feat/workflow-for-nitro-node branch 2 times, most recently from 12ab3fd to 5e57852 Compare February 27, 2024 09:30
@InNoobWeTrust InNoobWeTrust force-pushed the feat/workflow-for-nitro-node branch 5 times, most recently from f26be64 to e507b22 Compare February 27, 2024 10:23
@InNoobWeTrust InNoobWeTrust changed the title Add github workflow for nitro node ci: Add github workflow for nitro node Feb 27, 2024
@InNoobWeTrust InNoobWeTrust marked this pull request as ready for review February 27, 2024 16:34
louis-jan
louis-jan approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan
Copy link
Contributor

We are working on Cortex NPM and CLI so we could close this now.

@louis-jan louis-jan closed this Apr 25, 2024
@InNoobWeTrust
Copy link
Contributor Author

We are working on Cortex NPM and CLI so we could close this now.

Great, I'm waiting for the official NPM package then. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@InNoobWeTrust @louis-jan