Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install windows #47

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Install windows #47

merged 13 commits into from
Oct 6, 2023

Conversation

dotieuthien
Copy link
Contributor

@dotieuthien dotieuthien commented Oct 5, 2023 •
edited
Loading

  • Fix CMakeLists for dependencies
  • Add a line in llamaCPP controller to work on Windows because of conflict on our function and Windows built-in
  • Add guidline in README_temp

Address #27

tikikun
tikikun reviewed Oct 5, 2023
View reviewed changes
nitro_deps/CMakeLists.txt Outdated Show resolved Hide resolved
nitro_deps/CMakeLists.txt Outdated Show resolved Hide resolved
controllers/llamaCPP.h Show resolved Hide resolved
nitro_deps/CMakeLists.txt Outdated Show resolved Hide resolved
@dotieuthien dotieuthien linked an issue Oct 5, 2023 that may be closed by this pull request
Build and run Nitro on windows (with or without NVIDIA GPU support) #27
Closed
@dotieuthien dotieuthien added the P0: critical Mission critical label Oct 5, 2023
@dotieuthien dotieuthien self-assigned this Oct 5, 2023
hiro-v
hiro-v approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@hiro-v hiro-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok

@hiro-v hiro-v merged commit 6112ff3 into main Oct 6, 2023
4 checks passed
@hiro-v hiro-v deleted the install-windows branch October 6, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikikun tikikun tikikun left review comments

@hiro-v hiro-v hiro-v approved these changes

Assignees

@dotieuthien dotieuthien

Labels
P0: critical Mission critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build and run Nitro on windows (with or without NVIDIA GPU support)
3 participants
@dotieuthien @tikikun @hiro-v