Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cpuinfo as node module - new build scripts #813

Merged
merged 3 commits into from
Jul 3, 2024
Merged

feat: cpuinfo as node module - new build scripts #813

merged 3 commits into from
Jul 3, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 2, 2024 •
edited
Loading

Describe Your Changes

  • This pull request is to remove executable CPU info files and build it as a Node module, which is Node-friendly. Also replaced Bun build scripts since it's blocking code signing stuff. Replaced by ncc + pkg.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the feat/cpuinfo-node-binding branch 3 times, most recently from 5ef25df to 571f5fb Compare July 2, 2024 07:59
@louis-jan louis-jan changed the title feat: cpuinfo-as-node-module-new-build-scripts feat: cpuinfo as node module - new build scripts Jul 2, 2024
@louis-jan louis-jan force-pushed the feat/cpuinfo-node-binding branch 8 times, most recently from cb7c595 to 049fd2a Compare July 2, 2024 17:08
@hiento09 hiento09 force-pushed the feat/cpuinfo-node-binding branch 4 times, most recently from 55faa43 to 1c26e04 Compare July 3, 2024 06:17
@hiento09 hiento09 merged commit 36c247f into dev Jul 3, 2024
29 checks passed
@hiento09 hiento09 deleted the feat/cpuinfo-node-binding branch July 3, 2024 06:52
@hiento09 hiento09 restored the feat/cpuinfo-node-binding branch July 3, 2024 09:54
louis-jan added a commit that referenced this pull request Jul 3, 2024
@louis-jan
Revert "feat: cpuinfo as node module - new build scripts (#813)"
cbb7066 
This reverts commit 36c247f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@hiento09 hiento09 hiento09 approved these changes

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: CPU Info not found
4 participants
@louis-jan @namchuai @hiento09 @hientominh