chore: error output logs for cortex run #818
Conversation
louis-jan
force-pushed
the
fix/error-logs-cortex-run
branch
from
458964b
to
0ba712e
Compare
|
Removed |
louis-jan
force-pushed
the
fix/error-logs-cortex-run
branch
from
0ba712e
to
a37059e
Compare
chore: error handling - cortex run error outputs and logs file
louis-jan
force-pushed
the
fix/error-logs-cortex-run
branch
from
a37059e
to
654fe0f
Compare
| */ | ||
| export async function printLastErrorLines( | ||
| dataFolderPath: string, | ||
| numLines: number = 5, |
There was a problem hiding this comment.
stupid qn from me - any reason why only 5 lines (will they see a truncated error message?)
There was a problem hiding this comment.
non blocking curious qn, otherwise LGTM!
There was a problem hiding this comment.
stupid qn from me - any reason why only 5 lines (will they see a truncated error message?)
Yeah, that's a rough estimate for common cases. Since we output everything into the log file across sessions, we should output only several lines (not just errors), similar to other applications. Otherwise, there would be hundreds of lines of cortex-cpp printed out. The applications are not running in attached mode; in attached mode, users would see the full session logs.
chore: error handling - cortex run error outputs and logs file
Describe Your Changes
Added error outputs and log file
NOTES: Removed
Checking model files for existing...cortex run: Loading statuscortex run: Error outputs from cortex-jscortex run: Error outputs from cortex-cppcortex pull: with remote URLFixes Issues
runandstart#801Self Checklist