Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check cuda version for Tensorrt-llm models #832

Merged
merged 6 commits into from
Jul 4, 2024
Merged

feat: check cuda version for Tensorrt-llm models #832

merged 6 commits into from
Jul 4, 2024

Conversation

marknguyen1302
Copy link
Contributor

@marknguyen1302 marknguyen1302 commented Jul 4, 2024 •
edited
Loading

Describe Your Changes

  • Add check that require Cuda versions > 12.3
image Screenshot 2024-07-04 at 17 39 28

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

louis-jan
louis-jan approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marknguyen1302 marknguyen1302 merged commit 5859371 into dev Jul 4, 2024
1 check passed
@marknguyen1302 marknguyen1302 deleted the feat/check-cuda-version branch July 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marknguyen1302 @louis-jan