Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #644 - model start attach mode can just work once #851

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: #644 - model start attach mode can just work once #851

merged 1 commit into from
Jul 8, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 7, 2024 •
edited
Loading

Describe Your Changes

  • Fixed an issue where cortex models start can just attach once. Where cortex-cpp server shell injection can just done once. Now it observes log file instead. So can attach from any processes.
  • Fixed an issue where the model loading indicator keeps showing when the model is already loaded before.
  • Added Model is running indicator in attached mode
Screenshot 2024-07-07 at 13 33 27

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the fix/644-cortex-start-attach-does-not-work branch from abaf5b6 to f58f139 Compare July 7, 2024 06:51
@louis-jan louis-jan merged commit 828b679 into dev Jul 8, 2024
1 check passed
@louis-jan louis-jan deleted the fix/644-cortex-start-attach-does-not-work branch July 8, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: cortex start -a doesn't attach interactive shell
2 participants
@louis-jan @marknguyen1302