Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Output JS-compatible line numbers #5277

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

helixbass
Copy link
Collaborator

@GeoffreyBooth re-opening against master

See original PR: #5264

@thisredone
Copy link

Hey, are you still working on this? coffeescript really needs line numbers in stack traces fixed

@helixbass
Copy link
Collaborator Author

This should only affect line numbers in files which use irregular linebreak characters, so not sure if it's likely to address your issue

Can you give an example though where it's currently incorrect?

@thisredone
Copy link

There's something here: #5129
It's sort of strange. I guess maybe no one but me is using the coffee binary but I honestly don't remember the last time I've worked on a project (and I work on a lot of projects of all sizes on both Linux and Windows) that had correct stack traces.

@GeoffreyBooth
Copy link
Collaborator

I don't doubt there's an issue, but to fix it we need a minimal reproducible case. If you could provide as small an example as possible where the line numbers are wrong, either for stack traces or source maps, that would give us what we need to fix the bug.

@wdavidw
Copy link

wdavidw commented Aug 30, 2021

Just to confirm on my side, line numbers are incorrect with .coffee.md extensions, it has been the case for ages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants