Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid free variable conflicts within descendant scopes instead of global #5398

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Avoid free variable conflicts within descendant scopes instead of global #5398

wants to merge 6 commits into from

Commits on Jan 25, 2022

  1. Avoid free variable conflicts within descendant scopes instead of global 

    Instead of a global `referencedVars` option that is computed at the
lexer level (via all IDENTIFIER tokens), recurse through the AST to mark
each scope with all variables used within it and descendant scopes.

Likely also more efficient via `Set`s instead of `Array`s.

Also fix some missing `children` in `For` nodes, which otherwise caused
this rewrite to fail.

Fixes jashkenas#4865 by causing parameter renaming in fewer (more predictable)
scenarios.
    @edemaine
    edemaine committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    fd0d180 View commit details
    Browse the repository at this point in the history

  2. Changes to compiler caused by this PR

    @edemaine
    edemaine committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    1ee19f9 View commit details
    Browse the repository at this point in the history

  3. Browser build

    @edemaine
    edemaine committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    7b2bdf4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge remote-tracking branch 'upstream/main' into referenced-vars

    @edemaine
    edemaine committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    6456b4f View commit details
    Browse the repository at this point in the history

  2. Add comments

    @edemaine
    edemaine committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    fed48fe View commit details
    Browse the repository at this point in the history

  3. Rebuild

    @edemaine
    edemaine committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    2ab383d View commit details
    Browse the repository at this point in the history