Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Fix for ruby bug when using 地 in sentences and config bug #136

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jay-pee
Copy link

@jay-pee jay-pee commented Jun 6, 2020

In the comment at #134 I expanded a bit on the problem.

Screenshot from 2020-06-06 16-30-32

You can see that the word separation is wrong: 地问 (dewen) is written as one word. (or is it correct?)
Maybe the separation has to be improved...

@jay-pee jay-pee changed the title Fix for issue #134 Fix for ruby bug when using 地 in sentences Jun 6, 2020
@jay-pee
Copy link
Author

jay-pee commented Jun 8, 2020

Added a solution for issue #127

Sorry this was kind of automatically added to the older PR. Should have reset my git repo to the original state and then submit a new PR.

@jay-pee jay-pee changed the title Fix for ruby bug when using 地 in sentences Fix for ruby bug when using 地 in sentences and config bug Jun 8, 2020
@jay-pee
Copy link
Author

jay-pee commented Jun 8, 2020

I overlooked some use of the deleted class, which now leads to errors. Have to investigate further.

Also remove unecessary config.save statement
@jay-pee
Copy link
Author

jay-pee commented Jun 12, 2020

Had to reintroduce config.py so the function get_fields() is available again. But it is now much shorter since a lot of the old functionality could be replaced by inheriting from defaultdict.

@khonkhortisan
Copy link

khonkhortisan commented Jun 27, 2020

In case no one saw this: in that screenshot, Color blue 说 shows as Pinyin blue shuì and Bopomofo red ㄕㄨㄛ (shuō) instead of blue ㄕㄨㄟˋ (shuì). I'm interested in what the Ruby (Bopomofo) field looks like, whether 说 is in red-on-blue or just one color.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants