Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create espressowifi.env #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create espressowifi.env #12

wants to merge 1 commit into from

Conversation

oupala
Copy link
Contributor

@oupala oupala commented May 24, 2019

Create an env file for the Samsung Galaxy Tab 2 7.0 / Tab 2 10.1 (Wi-Fi / Wi-Fi + IR).

Create an env file for the Samsung Galaxy Tab 2 7.0 / Tab 2 10.1 (Wi-Fi / Wi-Fi + IR).
@oupala
Copy link
Contributor Author

oupala commented May 24, 2019

I'm not sure if the device codename should be espressowifi or espresso-common as the binary blobs of espressowifi and espresso3g have been merged into espresso-common.

See the pull request p31xx/p51xx: merge same blobs into espresso-common & updates for M.

@jfloff
Copy link
Owner

jfloff commented May 26, 2019

It should probably be expresso-common. Have you tried the image to see if it works as is?

@oupala
Copy link
Contributor Author

oupala commented May 26, 2019

It is a good idea. I have not tested it yet. I'll do that and I'll come back here with the answer.

@oupala
Copy link
Contributor Author

oupala commented Sep 6, 2019

I tried the following command line:

docker run --rm --privileged \
   -v "$(pwd)/android":/home/lineageos \
   -e GIT_USER_NAME=jfloff \
   -e [email protected] \
   -e DEVICE_CODENAME=expresso-common \
   -ti jfloff/lineageos lineageos init build

and I rapidly get an error:

[INFO] Setup 'build/envsetup.sh'
including device/generic/mini-emulator-arm64/vendorsetup.sh
including device/generic/mini-emulator-armv7-a-neon/vendorsetup.sh
including device/generic/mini-emulator-x86/vendorsetup.sh
including device/generic/mini-emulator-x86_64/vendorsetup.sh
including device/samsung/espressowifi/vendorsetup.sh
including device/samsung/serranoltexx/vendorsetup.sh
including device/sony/suzuran/vendorsetup.sh
including vendor/cm/vendorsetup.sh
including sdk/bash_completion/adb.bash
including vendor/cm/bash_completion/git.bash
including vendor/cm/bash_completion/repo.bash
including vendor/cm/vendorsetup.sh

** Invalid variant: 'common'
** Must be one of user userdebug eng
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.
Device expresso not found. Attempting to retrieve device repository from LineageOS Github (http://github.com/LineageOS).
Repository for expresso not found in the LineageOS Github repository list. If this is in error, you may need to manually add it to your local_manifests/roomservice.xml.
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.

** Don't have a product spec for: 'expresso'
** Do you have the right repo manifest?

[INFO] Export environment setup into '/home/lineageos/.lineageos_dev_init'.
[DONE] Init done.
[INFO] Building LineageOS ...
including device/generic/mini-emulator-arm64/vendorsetup.sh
including device/generic/mini-emulator-armv7-a-neon/vendorsetup.sh
including device/generic/mini-emulator-x86/vendorsetup.sh
including device/generic/mini-emulator-x86_64/vendorsetup.sh
including device/samsung/espressowifi/vendorsetup.sh
including device/samsung/serranoltexx/vendorsetup.sh
including device/sony/suzuran/vendorsetup.sh
including vendor/cm/vendorsetup.sh
including sdk/bash_completion/adb.bash
including vendor/cm/bash_completion/git.bash
including vendor/cm/bash_completion/repo.bash
Set cache size limit to 50.0 Gbytes
including vendor/cm/vendorsetup.sh

** Invalid variant: 'common'
** Must be one of user userdebug eng
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.
Device expresso not found. Attempting to retrieve device repository from LineageOS Github (http://github.com/LineageOS).
Repository for expresso not found in the LineageOS Github repository list. If this is in error, you may need to manually add it to your local_manifests/roomservice.xml.
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.

** Don't have a product spec for: 'expresso'
** Do you have the right repo manifest?

including vendor/cm/vendorsetup.sh

** Invalid variant: 'common'
** Must be one of user userdebug eng
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.
Device expresso not found. Attempting to retrieve device repository from LineageOS Github (http://github.com/LineageOS).
Repository for expresso not found in the LineageOS Github repository list. If this is in error, you may need to manually add it to your local_manifests/roomservice.xml.
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.
build/core/product_config.mk:249: *** Can not locate config makefile for product "expresso". Stop.

** Don't have a product spec for: 'expresso'
** Do you have the right repo manifest?

No such item in brunch menu. Try 'breakfast'

It is strange to see that expresso-common has been transformed into common, as it has been badly parsed.

@oupala
Copy link
Contributor Author

oupala commented Sep 6, 2019

I then tried the following command line:

docker run --rm --privileged \
   -v "$(pwd)/android":/home/lineageos \
   -e GIT_USER_NAME=jfloff \
   -e [email protected] \
   -e DEVICE_CODENAME=espressowifi \
   -ti jfloff/lineageos lineageos init build

The container then compile for a while and I finally get another error:

============================================
including vendor/cm/vendorsetup.sh
Looking for dependencies in device/samsung/espressowifi

============================================
PLATFORM_VERSION_CODENAME=REL
PLATFORM_VERSION=7.1.2
LINEAGE_VERSION=14.1-20190906-UNOFFICIAL-espressowifi
TARGET_PRODUCT=lineage_espressowifi
TARGET_BUILD_VARIANT=userdebug
TARGET_BUILD_TYPE=release
TARGET_BUILD_APPS=
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
TARGET_CPU_VARIANT=cortex-a9
TARGET_2ND_ARCH=
TARGET_2ND_ARCH_VARIANT=
TARGET_2ND_CPU_VARIANT=
HOST_ARCH=x86_64
HOST_2ND_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-4.18.0-25-generic-x86_64-with-debian-9.9
HOST_CROSS_OS=windows
HOST_CROSS_ARCH=x86
HOST_CROSS_2ND_ARCH=x86_64
HOST_BUILD_TYPE=release
BUILD_ID=NJH47F
OUT_DIR=/home/lineageos/out
============================================
make: Entering directory '/home/lineageos'
============================================
PLATFORM_VERSION_CODENAME=REL
PLATFORM_VERSION=7.1.2
LINEAGE_VERSION=14.1-20190906-UNOFFICIAL-espressowifi
TARGET_PRODUCT=lineage_espressowifi
TARGET_BUILD_VARIANT=userdebug
TARGET_BUILD_TYPE=release
TARGET_BUILD_APPS=
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
TARGET_CPU_VARIANT=cortex-a9
TARGET_2ND_ARCH=
TARGET_2ND_ARCH_VARIANT=
TARGET_2ND_CPU_VARIANT=
HOST_ARCH=x86_64
HOST_2ND_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-4.18.0-25-generic-x86_64-with-debian-9.9
HOST_CROSS_OS=windows
HOST_CROSS_ARCH=x86
HOST_CROSS_2ND_ARCH=x86_64
HOST_BUILD_TYPE=release
BUILD_ID=NJH47F
OUT_DIR=/home/lineageos/out
============================================
Running kati to generate build-lineage_espressowifi.ninja...
Environment variable BUILD_NUMBER was modified (69deea7b1d => c58e226c18), regenerating...
============================================
PLATFORM_VERSION_CODENAME=REL
PLATFORM_VERSION=7.1.2
LINEAGE_VERSION=14.1-20190906-UNOFFICIAL-espressowifi
TARGET_PRODUCT=lineage_espressowifi
TARGET_BUILD_VARIANT=userdebug
TARGET_BUILD_TYPE=release
TARGET_BUILD_APPS=
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
TARGET_CPU_VARIANT=cortex-a9
TARGET_2ND_ARCH=
TARGET_2ND_ARCH_VARIANT=
TARGET_2ND_CPU_VARIANT=
HOST_ARCH=x86_64
HOST_2ND_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-4.18.0-25-generic-x86_64-with-debian-9.9
HOST_CROSS_OS=windows
HOST_CROSS_ARCH=x86
HOST_CROSS_2ND_ARCH=x86_64
HOST_BUILD_TYPE=release
BUILD_ID=NJH47F
OUT_DIR=/home/lineageos/out
============================================
find: ‘/home/lineageos/out/target/common/obj/SHARED_LIBRARIES/libwifi-hal-mock_intermediates’: No such file or directory
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Argon.ogg:system/media/audio/alarms/Argon.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Carbon.ogg:system/media/audio/alarms/Carbon.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Krypton.ogg:system/media/audio/alarms/Krypton.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Neon.ogg:system/media/audio/alarms/Neon.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Osmium.ogg:system/media/audio/alarms/Osmium.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/alarms/ogg/Platinum.ogg:system/media/audio/alarms/Platinum.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/Effect_Tick_48k.ogg:system/media/audio/ui/Effect_Tick.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressDelete_120_48k.ogg:system/media/audio/ui/KeypressDelete.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressReturn_120_48k.ogg:system/media/audio/ui/KeypressReturn.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressSpacebar_120_48k.ogg:system/media/audio/ui/KeypressSpacebar.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressStandard_120_48k.ogg:system/media/audio/ui/KeypressStandard.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/KeypressInvalid_120_48k.ogg:system/media/audio/ui/KeypressInvalid.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/LowBattery.ogg:system/media/audio/ui/LowBattery.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/Trusted_48k.ogg:system/media/audio/ui/Trusted.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/VideoRecord_48k.ogg:system/media/audio/ui/VideoRecord.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/VideoStop_48k.ogg:system/media/audio/ui/VideoStop.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/WirelessChargingStarted.ogg:system/media/audio/ui/WirelessChargingStarted.ogg ignored.
PRODUCT_COPY_FILES frameworks/base/data/sounds/effects/ogg/camera_click_48k.ogg:system/media/audio/ui/camera_click.ogg ignored.
Starting build with ninja
ninja: Entering directory `.'
ninja: error: 'libsrv_init', needed by '/home/lineageos/out/target/product/espressowifi/obj/EXECUTABLES/pvrsrvinit_intermediates/pvrsrvinit.o', missing and no known rule to make it
build/core/ninja.mk:151: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/lineageos'

make failed to build some targets (25 seconds)

Is there something missing?

Note that I tried this with the official image, which does not have an espressowifi.env file in the device-config directory.

I think I need your help to go further.

@oupala
Copy link
Contributor Author

oupala commented Sep 25, 2019

Hi, I really need your help so that I can go further.

When trying to build lineage for the espressowifi device, using the current latest image from docker hub, the build is not stopping at the beginning but is going quite far, ending with an error that looks mysterious for me.

Can you please help me a little but diagnose the error?

@jfloff
Copy link
Owner

jfloff commented Sep 26, 2019

I can try sure. Do you have the logs? What is the full docker command you are running?

@oupala
Copy link
Contributor Author

oupala commented Sep 26, 2019

Thanks @jfloff. The command I used and part of the logs are in my previous comment, 20 days ago.

@oupala
Copy link
Contributor Author

oupala commented Oct 14, 2019

I built 2 images, one for espressowifi device, and the other one for espresso-common device.

The first image - with espressowifi - is starting the build of the lineageos package then fails at the point documented in a previous comment of 6 sept.

The second image - with espresso-common - is starting the build of the lineageos package then fails at the point where it seems that the dash between espresso and common is a problem itself:

** Invalid variant: 'common'
** Must be one of user userdebug eng
build/core/product_config.mk:249: *** Can not locate config makefile for product "espresso". Stop.
Device espresso not found. Attempting to retrieve device repository from LineageOS Github (http://github.com/LineageOS).
[...]
** Don't have a product spec for: 'espresso'
** Do you have the right repo manifest?

espresso seems to be considered as the device, and common as a variant for this device.

The problem is that espresso is not a valid device and common is not a valid variant.

There is probably something special about the espressowifi device that I don't understand. Could you please help me diagnose the problem as I have no idea on how to go further on my side...

@oupala
Copy link
Contributor Author

oupala commented Dec 22, 2019

@jfloff Would you have some free time to help building an lineage OS image for espressowifi?

@oupala
Copy link
Contributor Author

oupala commented Feb 14, 2020

Gentle reminder to beg for few help in order to fix this build.

Thanks @jfloff!

@oupala
Copy link
Contributor Author

oupala commented Aug 21, 2020

Is there any hope to get some help?

Is there anyone having an idea of the current version of repo?

@jfloff Have you a few minutes to help me just a little?

@MLXProjects
Copy link

Hi, when you have some files shared between devices (hence the usage of -common) you might add something to common folder's android.mk that allows to handle that. You can see this Android.mk as an example:
https://github.com/MLXProjects/android_device_samsung_rhea-common/blob/cm-11.0/Android.mk
The rhea-common folder goes at /device/samsung so aosp build command includes it only if you're building for a matching device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants