Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert "chore: clean up examples/alice_http_client" #217

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jul 2, 2024

@jhomlala I accidentally pushed the examples/alice_http_client clean-up (last of the series) directly to origian/master. 馃檲

No damage was done as it was just a clean-up of the example and I made sure it ran and worked both on Android and iOS, however, you should probably prevent pushes to master in the settings.

Here we can revert the push and make a PR if that's what you want, otherwise, you can close this PR.


This reverts commit 29a71db.

@techouse techouse requested a review from jhomlala July 2, 2024 20:31
@techouse techouse changed the title Revert "chore: clean up examples/alice_http_client" revert "chore: clean up examples/alice_http_client" Jul 2, 2024
@techouse techouse added the question Further information is requested label Jul 2, 2024
@jhomlala
Copy link
Owner

jhomlala commented Jul 3, 2024

I thought that I've protected this branch. I'll check.

@techouse techouse merged commit d8b2b67 into master Jul 3, 2024
2 checks passed
@techouse techouse deleted the revert/chore/examples/alice_http_client branch July 3, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants