Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable empty section #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Vrtak-CZ
Copy link
Contributor

We are not using GitLab issues so on every release this generates empty Closed issues section. In this PR I introduce RENDER_EMPTY_SECTIONS env variable (default is set to true). This env variable is responsible for disabling generation empty sections (if is set to false).

@Vrtak-CZ Vrtak-CZ requested a review from jk1z January 22, 2020 12:18
@Vrtak-CZ Vrtak-CZ force-pushed the empty-sections branch 2 times, most recently from f898add to f15b599 Compare January 22, 2020 12:25
@GlennM
Copy link

GlennM commented Jan 27, 2020

Think it would be good if you can add tests for the functionality as well?

@Vrtak-CZ
Copy link
Contributor Author

Vrtak-CZ commented Feb 3, 2020

test added

@Vrtak-CZ
Copy link
Contributor Author

@jk1z is there anything more I can do?

@IgorLesnevskiy
Copy link

@jk1z our team is also interested in this PR, any news about possible date of merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants