Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitlab api #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ A Gitlab release note generator that generates release note on latest tag
5. Generate a release note/changelog based on the findings above.

## Software requirement
- NodeJS ^10.x.x OR docker
- NodeJS ^16.x.x OR docker
- A gitlab personal access token with `api` permission. [How to Tutorial](https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html)

## How to run this app
Expand Down
2 changes: 1 addition & 1 deletion app/adapters/gitlab.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ module.exports = class GitlabAdapter {
async createTagReleaseByProjectIdTagNameAndTagId(projectId, tagName, body) {
const response = await Got.post(`${this.GITLAB_API_ENDPOINT}/projects/${projectId}/releases`, {
...this.gotDefaultOptions,
json: { ...body, tagName }
json: { ...body, tag_name: tagName }
});
return response.body;
}
Expand Down
2 changes: 1 addition & 1 deletion app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const container = ConfigureContainer();
(async () => {
try {
let env = null;
if (process.env.GITLAB_API_ENDPOINT && process.env.GITLAB_PROJECT_ID) {
if (process.env.GITLAB_PERSONAL_TOKEN && process.env.GITLAB_PROJECT_ID) {
// eslint-disable-next-line no-console
console.log(`Detected environment variable. Skipping CLI command.`);
env = process.env;
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.