-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX With Mariadb 11.1.2 ordering of table is broken #290 #291
base: 3.x-dev
Are you sure you want to change the base?
Conversation
Please be kind and add a test with the Mariadb 11.1.x version, see https://mariadb.com/kb/en/mariadb-11-1-3-release-notes/ |
This issue DOES effect Joomla 3 sites running on The fix to remove the function |
I have tested this successfully. We need this in the next Joomla Version asap. |
1 similar comment
I have tested this successfully. We need this in the next Joomla Version asap. |
We can't do this change because it would break the supported mysql versions for 3.x branch. Can you please add a version check to only use the "parent" implementation when mariadb >= 11.0 is used? |
I'm currently on rehabilitation and can't work on it from here. Perhaps someone else can take over. I'll be away for at least 6 weeks. |
@tkuschel My best wishes for you. I hope all will go well. Maybe @HLeithner or me can take over. |
Regarding the versions check see my alternative PR #300 . |
Pull Request for Issue #290
also see https://issues.joomla.org/tracker/joomla-cms/42333
Summary of Changes
Removed
public function selectRowNumber($orderBy, $orderColumnAlias)
inMysqlQueryBuilder.php
it already works within
DatabaseQuery.php
with window functionROW_NUMBER()
Testing Instructions
see https://issues.joomla.org/tracker/joomla-cms/42333
Documentation Changes Required
only valid for Joomla 5.x because MariaDB and MySQL miniumum