Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] fix check extension for update #35145

Closed
wants to merge 1 commit into from
Closed

[4] fix check extension for update #35145

wants to merge 1 commit into from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Aug 16, 2021

Summary of Changes

cast to int client_id

Testing Instructions

go to Extensions: Update
click on Check for updates
use postgresql

Actual result BEFORE applying this Pull Request

`An error has occurred.

22 22P02, 7, ERROR: invalid input syntax for integer: "" LINE 3: ...ement = 'job' AND type = 'plugin' AND client_id = '' AND fol... ^ `

Expected result AFTER applying this Pull Request

it shows extension updates

@zero-24
Copy link
Contributor

zero-24 commented Aug 16, 2021

Can you show us the update server that gets this error? The client_id fallback in the XML is removed with 4.0 and the "client" [admininstator|site] should now be used without fallback

@alikon
Copy link
Contributor Author

alikon commented Aug 16, 2021

@zero-24
Copy link
Contributor

zero-24 commented Aug 16, 2021

See: alikon/testcom#6

@alikon
Copy link
Contributor Author

alikon commented Aug 16, 2021

merged
i was confused by : https://docs.joomla.org/Deploying_an_Update_Server

Warning! Plugins and front-end modules are automatically installed with a client of 0 (site), but you will need to specify the client in an update or it will default to 1 (administrator) and then found update would not be shown because it would not match any extension.

@alikon alikon closed this Aug 16, 2021
@alikon alikon deleted the patch-134 branch August 16, 2021 08:06
@ChristineWk
Copy link

@alikon Similar to this Issue? widgetfactory/jce#95 (comment)
Don't know ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35145.

@alikon
Copy link
Contributor Author

alikon commented Aug 16, 2021

yes alikon/testcom#6 fixed it, they need
<client>site</client> in the plugin manifest

@zero-24
Copy link
Contributor

zero-24 commented Aug 16, 2021

The new client setting works for 3.x already too but we had a fallback thats gone since nearly one year in 4.0: #28767

@shawn61cp
Copy link

I am experiencing this issue on both an upgrade to, and a fresh install of, J! 4.2.8. I get this error any time I install an extension.
Joomla!: 4.2.8
PostgreSQL: 14
Ubuntu: 22.04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants