Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_two_ints test sometimes fail in noetic #741

Open
knorth55 opened this issue Jan 27, 2023 · 2 comments
Open

add_two_ints test sometimes fail in noetic #741

knorth55 opened this issue Jan 27, 2023 · 2 comments

Comments

@knorth55
Copy link
Member

knorth55 commented Jan 27, 2023

!
the test relaxed in #738, but still fails

noetic test of current master branch has the test error.
https://github.com/jsk-ros-pkg/jsk_roseus/actions/runs/4011982812/jobs/6897751532
https://github.com/jsk-ros-pkg/jsk_roseus/actions/runs/4009339630/jobs/6884572252
https://github.com/jsk-ros-pkg/jsk_roseus/actions/runs/4006511947/jobs/6878129815

2023-01-26T14:02:21.8527332Z [roseus.rosunit-add_two_ints/test-add-two-ints-many][FAILURE]-------------------
2023-01-26T14:02:21.8527860Z Test:(or (< service-call-error 5) (= (+ (send req :a) (send req :b)) (send res :sum)))
2023-01-26T14:02:21.8528263Z Trace:"^[33m[6] integration failure (1130+4903400)=4904530(nil)/=0(nil)
2023-01-26T14:02:21.8528748Z ^[0mation failure (1092+80664777)=80665869(nil)/=0(nil)
2023-01-26T14:02:21.8529594Z ^[0m951"
2023-01-26T14:02:21.8530042Z Message:"integration failure 6 times ... (1130+4903400)=4904530(nil)/=0(nil)"
2023-01-26T14:02:21.8530726Z --------------------------------------------------------------------------------
2023-01-26T14:02:21.8531058Z 
2023-01-26T14:02:21.8531169Z 
2023-01-26T14:02:21.8531462Z [roseus.rosunit-add_two_ints/test-add-two-ints-many][FAILURE]-------------------
2023-01-26T14:02:21.8532066Z Test:(or (< service-call-error 5) (= (+ (send req :a) (send req :b)) (send res :sum)))
2023-01-26T14:02:21.8532502Z Trace:"^[33m[5] integration failure (1092+80664777)=80665869(nil)/=0(nil)
2023-01-26T14:02:21.8532824Z ^[0m951(nil)
2023-01-26T14:02:21.8533480Z taclass #X55a1a0f5b4b0 bignum&gt;)
2023-01-26T14:02:21.8534144Z ø_ö ¡U"
2023-01-26T14:02:21.8534842Z Message:"integration failure 5 times ... (1092+80664777)=80665869(nil)/=0(nil)"
2023-01-26T14:02:21.8535440Z --------------------------------------------------------------------------------
2023-01-26T14:02:21.8535710Z 
2023-01-26T14:02:21.8536098Z [roseus.rosunit-add_two_ints/test-add-two-ints-persistent-many][passed]
2023-01-26T14:02:21.8536319Z 

ref. #732

@knorth55
Copy link
Member Author

knorth55 commented Jan 27, 2023

@knorth55 knorth55 changed the title Noetic test fails Noetic test sometimes fail Jan 27, 2023
@knorth55 knorth55 changed the title Noetic test sometimes fail add_two_ints test sometimes fail in noetic Jan 27, 2023
@knorth55
Copy link
Member Author

knorth55 commented Jan 27, 2023

2023-01-27T13:48:06.0921645Z [roseus:make] �[0m�[32mRequesting 1073741824(nil) + 1073741823(nil) -> 2147483647(nil)
2023-01-27T13:48:06.0946602Z 
2023-01-27T13:48:06.0946610Z 
2023-01-27T13:48:06.0946930Z                                                                                 
2023-01-27T13:48:06.0947561Z [roseus:make] �[0m�[31m[ERROR] [1674827286.093384795]: attempted to call service  /add_two_ints, but failed �[0m
2023-01-27T13:48:06.0987746Z 
2023-01-27T13:48:06.0987754Z 
2023-01-27T13:48:06.0988092Z                                                                                 
2023-01-27T13:48:06.0988955Z [roseus:make] �[31m[ERROR] test (= (+ (send req :a) (send req :b)) (send res :sum)) failed ... (integration failure (1073741824+1073741823)=2147483647(nil)/=0(nil) ^[0mmRequesting 1073741824(nil) + 1073741823(nil) -&gt; 2147483647(nil)
2023-01-27T13:48:06.0989651Z 
2023-01-27T13:48:06.0989783Z                                                                                 
2023-01-27T13:48:06.0990051Z [roseus:make] 93951(nil)

I found it is a bit odd that there is no error except attempted to call service /add_two_ints, but failed.

As code below, there are two more ros-error, deserializing and establishing errors,
but no error is printed in CI output.
🤔

jsk_roseus/roseus/roseus.cpp

Lines 1159 to 1190 in fa36ffd

bool bSuccess = true;
ros::SerializedMessage ser_req = ros::serialization::serializeMessage(request);
ros::SerializedMessage ser_resp;
if (link && link->isValid()) {
bSuccess = link->call(ser_req, ser_resp);
if ( bSuccess ) {
try {
ros::serialization::deserializeMessage(ser_resp, response);
} catch (std::exception& e) {
ROS_ERROR("Exception thrown while deserializing service call: %s", e.what());
bSuccess = false;
}
boost::shared_ptr<map<string, string> >connection_header = link->getConnection()->getHeader().getValues();
#if DEBUG
cerr << __PRETTY_FUNCTION__ << endl;
cerr << "c_header == " << connection_header << endl;
for(map<string, string>::iterator it = connection_header->begin(); it != connection_header->end(); it++){
cerr << " " << it->first << " : " << it->second << endl;
}
#endif
response._connection_header = connection_header;
StoreConnectionHeader(&response);
link.reset();
// If we're shutting down but the node haven't finished yet, wait until we do
while (ros::isShuttingDown() && ros::ok()) {
ros::WallDuration(0.001).sleep();
}
}
} else {
bSuccess = false;
ROS_ERROR("Failed to establish connection to service server");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant