Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use shields.io built-in JSR logo for badges #487

Merged
merged 1 commit into from
May 9, 2024

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented May 7, 2024

The JSR logo has been added to Simple Icons since simple-icons/simple-icons#10794.

I used the logoSize parameter to make the logo fit the badge. The feature was introduced at badges/shields#9191.

Currently, we can't use logoSize in the response due to badges/shields#10132. So I passed these parameters with search parameters instead.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucacasonato lucacasonato changed the title chore(badges): use shields.io built-in JSR logo refactor: use shields.io built-in JSR logo for badges May 8, 2024
@lucacasonato lucacasonato added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@lucacasonato lucacasonato added this pull request to the merge queue May 9, 2024
Merged via the queue into jsr-io:main with commit c784ee3 May 9, 2024
6 checks passed
@LitoMore LitoMore deleted the use-built-in-logo branch May 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants