Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese Strings #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sr093906
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #427 (59b1f97) into master (4f13047) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #427   +/-   ##
=========================================
  Coverage     28.36%   28.36%           
  Complexity      151      151           
=========================================
  Files            26       26           
  Lines          1893     1893           
  Branches        227      227           
=========================================
  Hits            537      537           
  Misses         1336     1336           
  Partials         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f13047...59b1f97. Read the comment docs.

Base automatically changed from master to main February 26, 2021 21:48
@julian-klode
Copy link
Owner

julian-klode commented Apr 15, 2021

@KevinSJ Can you/Do you want to review this?

<string name="action_save">完成</string>
<string name="load_defaults">加载默认设置</string>
<string name="action_about">关于</string>
<string name="info_app_license">本程序是自由软件:你可以根据自由软件基金会发布的 GNU 通用公共许可证的条款重新发布和/或修改它,要么是许可证的第三版,要么(根据你的选择)任何后续版本。</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's better to leave this in English, if you really want to translate this, you should follow the official GNU Chinese translation:
本软件是自由软件;你可以按照由自由软件基金会发布的GNU通用公共许可证来再发布该软件或者修改该软件;你可以使用该许可证的第3版,或者(作为可选项)使用该许可证的任何更新版本。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be translated so long as it is not labelled as untranslatable. Please use the official translation to replace mine, if possible.

<string name="updating_hostfiles">更新主机文件中</string>
<string name="action_use_file">使用文件</string>
<string name="persistable_uri_permission_failed">无法使用被请求的文件:不被允许持久使用请求的文件</string>
<string name="updating_n_host_files">正在更新 %1$d 主机文件</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julian-klode I am a bit confused about context here, in the previous translation that I made, I thought your were refering to the hosts file as in hosts file in the os, so I just leave host part as is which I think is the convention in most Chinese translation. The current translator translate it to mean host as in network host.

@sr093906
I feels it is a bit strange to translate host file as '主机文件', see Wikipedia page

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's a reliable source, also the first paragraph reads: '操作系统使用Hosts 文件将人性化的主机名映射到数字 Internet 协议 (IP) 地址,该 IP 地址识别和定位 IP 网络中的主机。 Hosts 文件是多种系统资源的一种,它们可以为计算机网络中的网络节点寻址,是操作系统 IP 实施的通用部分。' The microsoft doc is the only tech doc that translate Hosts file to 主机文件, and MS has a history of using machine translate on their tech docs.

Copy link
Author

@sr093906 sr093906 Apr 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you ignore the article title ? Microsoft doc is not a reliable source. I partially agree.But if you prefer Wikipedia over official technical document. Then I have no comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not comment over this issue again. The thing I care is when will the updated Chinese translation be merged? @julian-klode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the Chinese developers I know will call Host file 主机文件. That's the end of this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants